rm-hull / chakra-error-fallback / 19804624793

92%

push

github

fix: Handle cyclic error causes gracefully (#47)

* fix: Handle cyclic error causes gracefully

The `Cause` component now uses a `seen` set to track errors it has
already processed. This prevents the component from entering an
infinite rendering loop when error objects form a cycle via the
`error.cause` property.

A test case and a Storybook story were added to verify the behavior.

* fix: Initialize Set defensively in Cause

Ensure that the `seen` prop passed to the `Cause` component
is always iterable when constructing `nextSeen`. If `seen` is
nullish, an empty array (`[]`) is used instead to prevent
potential runtime errors.

* test: Use render function for cyclic errors story

The setup for the cyclic error objects (`errorA`, `errorB`) is moved
from the module scope into the story's `render` function.

This ensures that a fresh error object cycle is created on every
render, which prevents potential state leakage or caching issues
within Storybook. The `cause` is set using `defineProperty`.

* style: Improve formatting in ErrorFallback files

Applied minor formatting improvements across the `ErrorFallback`
component files:

*   Adjusted indentation and spacing in `ErrorFallback.stories.tsx`.
*   Added or adjusted trailing commas in `ErrorFallback.test.tsx`
    for better consistency.

* refactor: Hide internal cycle tracking in Cause

Splits the `Cause` component into an exported wrapper and an
internal recursive component (`InternalCause`).

This change ensures that the internal state tracking (`seen` set)
used for detecting circular references is encapsulated,
simplifying the public API of the exported `Cause` component.

27 of 31 branches covered (87.1%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

59 of 62 relevant lines covered (95.16%)

5.95 hits per line