facet-rs / facet / 19803957999

58%

Build Type

push

github

Committed by fasterthanlime

Commit Message

Add explicit crate_path to define_attr_grammar! for $crate hygiene fix

The $crate metavariable only resolves during declarative macro expansion.
When passed to a proc macro, it becomes literal tokens that don't resolve.

Solution: Extension crates now explicitly declare their crate path:

    facet::define_attr_grammar! {
        ns "args";
        crate_path ::facet_args;
        pub enum Attr { ... }
    }

The proc macro outputs e.g. `::facet_args::Attr::Short(...)` which
resolves correctly at any call site.

Changes:
- Add crate_path declaration parsing to grammar DSL
- Update __dispatch_attr to use crate_path in output
- Migrate facet-args, facet-yaml, facet-kdl to use crate_path
- Update facet-args runtime to downcast to &Attr enum

Run Details

50 of 200 new or added lines in 5 files covered. (25.0%)

2 existing lines in 2 files now uncovered.

18910 of 32581 relevant lines covered (58.04%)

179.47 hits per line