FlexMeasures / flexmeasures / 19800994086

74%

push

github

Chore: add external id editing and include in cli output (#1806)

* enable editing of external_id in UI and API

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* include external_id in CLI when showing asset

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* add changelog entry

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* Update flexmeasures/ui/templates/assets/asset_properties.html

Co-authored-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>
Signed-off-by: Nicolas Höning <iam@nicolashoening.de>

* Update flexmeasures/ui/views/assets/forms.py

Co-authored-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>
Signed-off-by: Nicolas Höning <iam@nicolashoening.de>

* rolling back db session manually before redirecting, so that happens clean in case of a db error

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* give two other fields descriptions, as well. Align edit and new asset forms a little

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* Give prope example for sensors_to_show_as_kpis

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* emphasize that we cannot validate the external ID in the form

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* enhance schema field with metadata

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* docs: update description and example entry

Signed-off-by: F.N. Claessen <felix@seita.nl>

* chore: update openapi-specs.json

Signed-off-by: F.N. Claessen <felix@seita.nl>

* do not save empty strings for external_id, to prevent UniqueViolations

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* handle cases well when existing external Ids are removed, add comments, default in form can be explicitly None

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* testing the form should send empty string to model reality

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* add openapi step back to precommit

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

---------

Signed-off-by... (continued)

1387 of 2043 branches covered (67.89%)

Branch coverage included in aggregate %.

8 of 11 new or added lines in 4 files covered. (72.73%)

10244 of 13803 relevant lines covered (74.22%)

5.93 hits per line