ProjectOpenSea / opensea-js / 19773318375

88%

master: 30%

push

github

Fix: Support zero-payment private listings (#1834)

Fixes SDK crash when fulfilling zero-payment private listings (e.g., rewards claims).

Problem:
- constructPrivateListingCounterOrder crashes when paymentItems is empty
- fulfillPrivateOrder crashes accessing counterOrder.parameters.offer[0]

Solution (mirrors backend behavior in os2-core Seaport.kt):
- Allow empty payment items in constructPrivateListingCounterOrder
- Return counter order with offer: [] for zero-payment listings
- Add computePrivateListingValue() to calculate ETH value from original order
- Use computed value instead of counter order's offer[0].startAmount

This enables fulfillment of zero-payment private listings used for rewards
claims via REWARDS_PRIVATE_LISTING_CLAIM_WALLET.

Closes #1832

474 of 684 branches covered (69.3%)

Branch coverage included in aggregate %.

65 of 65 new or added lines in 3 files covered. (100.0%)

4105 of 4546 relevant lines covered (90.3%)

4.14 hits per line