bramp / build-along / 19770990533

89%

Build Type

push

github

Committed by bramp

Commit Message

Fix shine matching to require overlap with image

The shine classifier was incorrectly matching small drawings that were
merely near (within 10 units) but not actually overlapping the part image.
This caused small drawings below part images (e.g., decorations under the
count text) to be associated as shines, which expanded the part_image bbox
downward and broke the part-count-to-image pairing.

Fix: Require shine to overlap with the image, not just be nearby. Shines
that are below or completely outside the image are no longer matched.

This fixes the bug where 6433200_page_005 step 1 was missing its PartsList
despite having visible parts in the PDF.

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

23 existing lines in 5 files now uncovered.

8517 of 9432 relevant lines covered (90.3%)

0.9 hits per line