bramp / build-along / 19750739274

89%

push

github

refactor: convert Score details to be a abstract Score object with a score method that returns a Weight.

- Convert Score base class from ABC with @dataclass to Pydantic BaseModel
- Add Weight type alias (Annotated[float, Ge(0), Le(1)]) for score range
- Update all Score implementations to inherit from Pydantic BaseModel
- Change score() return type from float to Weight across all implementations
- Remove arbitrary_types_allowed from Candidate (no longer needed)
- Add isinstance check in step_classifier_test for _StepScore.sort_key()
- Pass config during Score construction instead of to score() method

Benefits:
- Better type safety with Weight indicating expected 0.0-1.0 range
- Proper Pydantic integration without special configuration
- Cleaner code without arbitrary_types_allowed workaround
- All Score objects properly validated and serializable

All tests passing, type checking successful.

74 of 80 new or added lines in 20 files covered. (92.5%)

7435 of 8276 relevant lines covered (89.84%)

0.9 hits per line