stacklok / toolhive / 19747939134

50%

Build Type

push

github

Committed by web-flow

Commit Message

Use standard JSON Schema format for VMCP composite tool parameters (#2651)

* Use standard JSON Schema format for VMCP composite tool parameters

Fixes #2650

Changes composite tool parameter definitions to use standard JSON Schema
format per the MCP specification, instead of a non-standard simplified format.

**Breaking Change**: Composite tool parameter format has changed from:
```yaml
parameters:
  param1:
    type: "string"
    default: "value"
```

To standard JSON Schema:
```yaml
parameters:
  type: object
  properties:
    param1:
      type: string
      default: "value"
  required: ["param1"]
```

Changes:
- Update CompositeToolConfig.Parameters to map[string]any (full JSON Schema)
- Remove parameter transformation logic from yaml_loader and workflow_converter
- Add JSON Schema validation in yaml_loader (checks type: object)
- Update Kubernetes CRDs to use runtime.RawExtension for parameters
- Update webhook validation to handle runtime.RawExtension
- Regenerate CRD manifests and deepcopy code
- Update all tests and documentation

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>

* Add test case verifying issue #2775 fields are preserved

Add explicit test case to converter_test.go that verifies
description and default fields at the parameter property level
are correctly preserved when using JSON Schema format.

This test documents that issue #2775 (field mismatch between
ParameterSpec and ParameterSchema) is resolved by the JSON Schema
approach, which supports all JSON Schema fields automatically.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Add comprehensive test coverage for issue #2775 field preservation

Add explicit test cases verifying that JSON Schema fields (description,
default, required) are preserved throughout the entire conversion chain:

1. conv... (continued)

Run Details

42 of 58 new or added lines in 5 files covered. (72.41%)

5 existing lines in 1 file now uncovered.

25613 of 51294 relevant lines covered (49.93%)

60.83 hits per line