spesmilo / electrum / 5008222085447680

62%

master: 63%

Pull #10325

CirrusCI

ln: fix race when doing concurrent ln payments

There is a race when initiating multiple lightning payments concurrently
(e.g. when doing a reverse swap with prepayment + swap payment).
suggest_splits might overallocate
split amounts for a channel as the splitting of both invoice amounts runs
concurrently and before acutal htlcs that reduce the channels balance
have been added to the channel yet. This results in a "not
enough balance" PaymentFailure once we try to send the htlcs and the
other payment attempt already reduced the available balance of the
channel.

This fix takes a lock from splitting the amount until the htlcs are
put on the channel, so suggest_splits always acts on the correct channel
balance.

5 of 5 new or added lines in 1 file covered. (100.0%)

23363 of 37561 relevant lines covered (62.2%)

0.62 hits per line