supabase / supavisor / 19741285883

65%

Build Type

push

github

Committed by web-flow

Commit Message

fix(defrag): improve statems, caching, logs, circuit breaking (#744)

This is a big "defrag" PR solving many of the paper cuts from the
current architecture:

### Secret caching
Ensure we don't store secrets inside start options, which caused
unintentional caching on the pool, and made it required to restart the
pool if a password changed.

Introduces a central secret caching module instead of relying on
arbitrary cachex calls.

Breaks into two types of secrets:
- validation secrets: used to validate credentials on connection
attempts, **can be skipped for users where we don't want caching, e.g.:
users with single use passwords**
- upstream secrets: used for connection. 

### Logs
- Reduces log duplication: terminate processes normally on expected
situations
- Better messages

### Pool termination
- Terminate pool early if Db doesn't exist anymore: this resolves an
issue where we would keep getting spammed by prisma shadow dbs that get
deleted but we would keep trying to connect to them.

### Circuit breaker
- Under situations we can't proceed (can't connect to the database,
can't get secrets) don't allow pool initialization. Give a user friendly
message.

### ClientHandler changes
- Break ClientHandler into more modules
- Break ClientHandler into more states, with no arbitrary socket
receives
- Try to isolate some parts of ClientHandler: error handling, auth, etc
- Remove dead code (read replicas)
- Some refactoring/renaming, e.g.: db_pid -> db_connection (it was a
tuple)
- Use state enter for state tracking in ClientHandler (removes manual
logger.metadata calls, adds telemetry)
- Improve active counting

### Breaking changes
Support for aliases removed

### Misc
- Better error decoding and formatting

Run Details

651 of 845 new or added lines in 25 files covered. (77.04%)

22 existing lines in 8 files now uncovered.

1851 of 2926 relevant lines covered (63.26%)

4216.46 hits per line