2954
74%
master: 51%

Ran 30 Aug 2016 01:28PM UTC

Jobs 3

Files 316

Run time 3min

Badge

Embed ▾

pending completion

Build # 2954

Build Type

push

travis-ci

Committed by

mhl

Commit Message

Fix lack of validation errors from /settings and a caching bug

No validation errors were being shown when trying to update settings at
/settings, because the form had the settings object instance set on it
in the wrong way: in get_context_data rather than via get_kwargs.

This commit fixes that, but this also exposed a bug where the cached
setting object was being updated when checking the validity of the
fields. This commit fixes that as well, otherwise the switch to
using get_form_kwargs causes test failures because of this bad
caching.

Run Details

7775 of 10438 relevant lines covered (74.49%)

2.23 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	2954.1	30 Aug 2016 01:28PM UTC	74.49	Travis Job 2954.1
2	2954.2	30 Aug 2016 01:31PM UTC	74.49	Travis Job 2954.2
3	2954.3	30 Aug 2016 01:29PM UTC	74.49	Travis Job 2954.3

Source Files on build 2954

Detailed source file information is not available for this build.

mysociety / yournextrepresentative / 2954
74%
master: 51%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2954

mysociety / yournextrepresentative / 2954 74% master: 51%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2954

mysociety / yournextrepresentative / 2954
74%
master: 51%

README BADGES
x