spesmilo / electrum / 5461428980678656

62%

master: 63%

Build Type

Pull #10325

CirrusCI

Committed by f321x

Commit Message

swaps: fix race when doing reverse swap

There is a race when doing a reverse swap using gossip with multiple
lightning channels.
If we do a swap with a larger amount, suggest_splits might overallocate
split amounts for a channel as the pathfinding of both invoices runs
concurrently and before acutal htlcs that reduce the channels balance
have been added to the channel yet. This will then result in a "not
enough balance" PaymentFailure once we try to send the htlcs.

Adding a little sleep between the different payments fixes this, a
conceptual fix probably would need larger changes in the splitting logic
by reserving the amount on a channel that will soon get sent?

Pull Request Pull Request #10325: swaps: fix race when doing reverse swap

Run Details

0 of 4 new or added lines in 1 file covered. (0.0%)

7 existing lines in 3 files now uncovered.

23357 of 37562 relevant lines covered (62.18%)

0.62 hits per line