pmd / pmd / 277

Committed 27 Nov 2025 01:37PM UTC coverage: 78.778% (+0.03%) from 78.749%

Build # 277

Build Type

push

github

Committed by

adangel

Commit Message

[java] UseArraysAsList: skip when if-statements (#6228)

Run Details

18419 of 24233 branches covered (76.01%)

Branch coverage included in aggregate %.

40090 of 50038 relevant lines covered (80.12%)

0.81 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

95.07

/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/symbols/table/internal/JavaResolvers.java

/*
 * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
 */

package net.sourceforge.pmd.lang.java.symbols.table.internal;

import static net.sourceforge.pmd.lang.java.symbols.table.internal.SuperTypesEnumerator.DIRECT_STRICT_SUPERTYPES;
import static net.sourceforge.pmd.lang.java.symbols.table.internal.SuperTypesEnumerator.JUST_SELF;
import static net.sourceforge.pmd.util.CollectionUtil.listOfNotNull;

import java.lang.reflect.Modifier;
import java.util.ArrayList;
import java.util.BitSet;
import java.util.Collections;
import java.util.List;
import java.util.Set;
import java.util.function.BiFunction;
import java.util.function.BinaryOperator;
import java.util.function.Function;
import java.util.function.Predicate;

import org.apache.commons.lang3.tuple.Pair;
import org.checkerframework.checker.nullness.qual.NonNull;
import org.checkerframework.checker.nullness.qual.Nullable;
import org.pcollections.HashTreePSet;
import org.pcollections.PSet;

import net.sourceforge.pmd.lang.java.symbols.JAccessibleElementSymbol;
import net.sourceforge.pmd.lang.java.symbols.JClassSymbol;
import net.sourceforge.pmd.lang.java.symbols.JElementSymbol;
import net.sourceforge.pmd.lang.java.symbols.JFieldSymbol;
import net.sourceforge.pmd.lang.java.symbols.JMethodSymbol;
import net.sourceforge.pmd.lang.java.symbols.JModuleSymbol;
import net.sourceforge.pmd.lang.java.symbols.SymbolResolver;
import net.sourceforge.pmd.lang.java.symbols.table.coreimpl.CoreResolvers;
import net.sourceforge.pmd.lang.java.symbols.table.coreimpl.NameResolver;
import net.sourceforge.pmd.lang.java.symbols.table.coreimpl.NameResolver.SingleNameResolver;
import net.sourceforge.pmd.lang.java.symbols.table.coreimpl.ShadowChainBuilder;
import net.sourceforge.pmd.lang.java.types.JClassType;
import net.sourceforge.pmd.lang.java.types.JMethodSig;
import net.sourceforge.pmd.lang.java.types.JTypeMirror;
import net.sourceforge.pmd.lang.java.types.JVariableSig;
import net.sourceforge.pmd.lang.java.types.JVariableSig.FieldSig;
import net.sourceforge.pmd.lang.java.types.TypeOps;
import net.sourceforge.pmd.lang.java.types.internal.infer.OverloadSet;
import net.sourceforge.pmd.util.AssertionUtil;
import net.sourceforge.pmd.util.CollectionUtil;

public final class JavaResolvers {

    private JavaResolvers() {
        // utility class
    }

    /** Prepend the package name, handling empty package. */
    static String prependPackageName(String pack, String name) {
        return pack.isEmpty() ? name : pack + "." + name;
    }

    /**
     * Returns true if the given element can be imported in the current file
     * (it's visible & accessible). This is not a general purpose accessibility
     * check and is only appropriate for imports.
     *
     *
     * <p>We consider protected members inaccessible outside of the package they were declared in,
     * which is an approximation but won't cause problems in practice.
     * In an ACU in another package, the name is accessible only inside classes that inherit
     * from the declaring class. But inheriting from a class makes its static members
     * accessible via simple name too. So this will actually be picked up by some other symbol table
     * when in the subclass. Usages outside of the subclass would have made the compilation fail.
     */
    static boolean canBeImportedIn(String thisPackage, JAccessibleElementSymbol member) {
        return isAccessibleIn(null, thisPackage, member, false);
    }

    static @NonNull NameResolver<JTypeMirror> moduleImport(Set<String> moduleNames,
                                                  final SymbolResolver symbolResolver,
                                                  final String thisPackage) {
        return new SingleNameResolver<JTypeMirror>() {
            @Override
            public @Nullable JTypeMirror resolveFirst(String simpleName) {
                for (String module : moduleNames) {
                    JModuleSymbol moduleSymbol = symbolResolver.resolveModule(module);

                    if (moduleSymbol == null) {
                        // TODO: log warning about incomplete auxclasspath
                        return null;
                    }

                    for (String packageName : moduleSymbol.getExportedPackages()) {
                        JClassSymbol sym = symbolResolver.resolveClassFromCanonicalName(packageName + "." + simpleName);
                        if (sym != null && canBeImportedIn(thisPackage, sym)) {
                            return sym.getTypeSystem().typeOf(sym, false);
                        }
                    }
                }

                return null;
            }

            @Override
            public String toString() {
                return "ModuleImportResolver(" + moduleNames + ")";
            }
        };
    }

    static @NonNull NameResolver<JTypeMirror> importedOnDemand(Set<String> lazyImportedPackagesAndTypes,
                                                      final SymbolResolver symResolver,
                                                      final String thisPackage) {
        return new SingleNameResolver<JTypeMirror>() {
            @Nullable
            @Override
            public JTypeMirror resolveFirst(String simpleName) {
                for (String pack : lazyImportedPackagesAndTypes) {
                    // here 'pack' may be a package or a type name, so we must resolve by canonical name
                    String name = prependPackageName(pack, simpleName);
                    JClassSymbol sym = symResolver.resolveClassFromCanonicalName(name);
                    if (sym != null && canBeImportedIn(thisPackage, sym)) {
                        return sym.getTypeSystem().typeOf(sym, false);
                    }
                }
                return null;
            }

            @Override
            public String toString() {
                return "ImportOnDemandResolver(" + lazyImportedPackagesAndTypes + ")";
            }
        };
    }

    static @NonNull NameResolver<JTypeMirror> packageResolver(SymbolResolver symResolver, String packageName) {
        return new SingleNameResolver<JTypeMirror>() {
            @Nullable
            @Override
            public JTypeMirror resolveFirst(String simpleName) {
                JClassSymbol sym = symResolver.resolveClassFromBinaryName(prependPackageName(packageName, simpleName));
                if (sym != null) {
                    return sym.getTypeSystem().typeOf(sym, false);
                }
                return null;
            }

            @Override
            public String toString() {
                return "PackageResolver(" + packageName + ")";
            }
        };
    }

    /** All methods in a type, taking care of hiding/overriding. */
    static NameResolver<JMethodSig> subtypeMethodResolver(JClassType t) {
        JClassSymbol nestRoot = t.getSymbol().getNestRoot();
        return new NameResolver<JMethodSig>() {
            @Override
            public @NonNull List<JMethodSig> resolveHere(String simpleName) {
                return t.streamMethods(
                    it -> it.nameEquals(simpleName)
                        && isAccessibleIn(nestRoot, it, true) // fetch protected methods
                        && isNotStaticInterfaceMethod(it)
                ).collect(OverloadSet.collectMostSpecific(t)); // remove overridden, hidden methods
            }

            // Static interface methods are not inherited and are in fact not in scope in the subtypes.
            // They must be explicitly qualified or imported.
            private boolean isNotStaticInterfaceMethod(JMethodSymbol it) {
                return !it.isStatic() || it.getEnclosingClass().equals(t.getSymbol())
                    || !it.getEnclosingClass().isInterface();
            }

            @Override
            public String toString() {
                return "methods of " + t;
            }
        };
    }

    /** Static methods with a given name. */
    static NameResolver<JMethodSig> staticImportMethodResolver(JClassType container, @NonNull String accessPackageName, String importedSimpleName) {
        assert importedSimpleName != null;
        assert accessPackageName != null;
        return new NameResolver<JMethodSig>() {
            @Override
            public @NonNull List<JMethodSig> resolveHere(String simpleName) {
                if (!simpleName.equals(importedSimpleName)) {
                    return Collections.emptyList();
                }
                return container.streamMethods(
                    it -> Modifier.isStatic(it.getModifiers())
                        && it.nameEquals(simpleName)
                        // Technically, importing a static protected method may be valid
                        // inside some of the classes in the compilation unit. This test
                        // makes it not in scope in those classes. But it's also visible
                        // from the subclass as an "inherited" member, so is in scope in
                        // the relevant contexts.
                        && canBeImportedIn(accessPackageName, it)
                ).collect(OverloadSet.collectMostSpecific(container)); // remove overridden, hidden methods
            }

            @Override
            public String toString() {
                return "static methods w/ name " + importedSimpleName + " of " + container;
            }
        };
    }

    /** Static fields with a given name. */
    static NameResolver<FieldSig> staticImportFieldResolver(JClassType containerType, @NonNull String accessPackageName, String importedSimpleName) {
        return new NameResolver<FieldSig>() {
            List<FieldSig> result;

            @Override
            public @NonNull List<FieldSig> resolveHere(String simpleName) {
                if (!simpleName.equals(importedSimpleName)) {
                    return Collections.emptyList();
                }
                if (result == null) {
                    result = JavaResolvers.getMemberFieldResolver(containerType, accessPackageName, null, simpleName)
                                          .resolveHere(simpleName);
                }
                return result;
            }

            @Override
            public String toString() {
                return "static methods w/ name " + importedSimpleName + " of " + containerType;
            }
        };
    }

    /** Static classes with a given name. */
    static NameResolver<JClassType> staticImportClassResolver(JClassType containerType, @NonNull String accessPackageName, String importedSimpleName) {
        return new NameResolver<JClassType>() {
            List<JClassType> result;

            @Override
            public @NonNull List<JClassType> resolveHere(String simpleName) {
                if (!simpleName.equals(importedSimpleName)) {
                    return Collections.emptyList();
                }

                if (result == null) {
                    result = JavaResolvers.getMemberClassResolver(containerType, accessPackageName, null, simpleName)
                                          .resolveHere(simpleName);
                }
                return result;
            }

            @Override
            public String toString() {
                return "static classes w/ name " + importedSimpleName + " of " + containerType;
            }
        };
    }

    static NameResolver<JMethodSig> staticImportOnDemandMethodResolver(JClassType container, @NonNull String accessPackageName) {
        assert accessPackageName != null;
        return new NameResolver<JMethodSig>() {
            @Override
            public @NonNull List<JMethodSig> resolveHere(String simpleName) {
                return container.streamMethods(
                    it -> Modifier.isStatic(it.getModifiers())
                        && it.nameEquals(simpleName)
                        && canBeImportedIn(accessPackageName, it)
                ).collect(OverloadSet.collectMostSpecific(container)); // remove overridden, hidden methods
            }

            @Override
            public String toString() {
                return "all static methods of " + container;
            }
        };
    }

    private static final BinaryOperator<List<JMethodSig>> STATIC_MERGER =
        (as, bs) -> methodMerger(true, as, bs);

    private static final BinaryOperator<List<JMethodSig>> NON_STATIC_MERGER =
        (as, bs) -> methodMerger(false, as, bs);


    static BinaryOperator<List<JMethodSig>> methodMerger(boolean inStaticType) {
        return inStaticType ? STATIC_MERGER : NON_STATIC_MERGER;
    }

    /**
     * Merges two method scopes, the otherResult is the one of an enclosing class,
     * the inner result is the one inherited from supertypes (which take precedence
     * in case of override equivalence).
     *
     * <p>Non-static methods of the outer result are excluded if the inner scope is static.
     */
    private static List<JMethodSig> methodMerger(boolean inStaticType, List<JMethodSig> myResult, List<JMethodSig> otherResult) {
        if (otherResult.isEmpty()) {
            return myResult;
        } // don't check myResult for emptiness, we might need to remove static methods

        // For both the input lists, their elements are pairwise non-equivalent.
        // If any element of myResult is override-equivalent to
        // another in otherResult, then we must exclude the otherResult

        BitSet isShadowed = new BitSet(otherResult.size());

        for (JMethodSig m1 : myResult) {
            int i = 0;
            for (JMethodSig m2 : otherResult) {
                boolean isAlreadyShadowed = isShadowed.get(i);
                if (!isAlreadyShadowed && TypeOps.areOverrideEquivalent(m1, m2)
                    || inStaticType && !m2.isStatic()) {
                    isShadowed.set(i); // we'll remove it later
                }
                i++;
            }
        }

        if (isShadowed.isEmpty()) {
            return CollectionUtil.concatView(myResult, otherResult);
        } else {
            List<JMethodSig> result = new ArrayList<>(myResult.size() + otherResult.size() - 1);
            result.addAll(myResult);
            copyIntoWithMask(otherResult, isShadowed, result);
            return Collections.unmodifiableList(result);
        }
    }

    /**
     * Copy the elements of the input list into the result list, excluding
     * all elements marked by the bitset.
     */
    private static <T> void copyIntoWithMask(List<? extends T> input, BitSet denyList, List<? super T> result) {
        int last = 0;
        for (int i = denyList.nextSetBit(0); i >= 0; i = denyList.nextSetBit(i + 1)) {
            if (last != i) {
                result.addAll(input.subList(last, i));
            }
            last = i + 1;
        }
        if (last != input.size()) {
            result.addAll(input.subList(last, input.size()));
        }
    }


    /**
     * Resolvers for inherited member types and fields. We can't process
     * methods that way, because there may be duplicates and the equals
     * of {@link JMethodSymbol} is not reliable for now (cannot differentiate
     * overloads). But also, usually a subset of methods is used in a subclass,
     * and it's ok performance-wise to process them on-demand.
     */
    static Pair<NameResolver<JTypeMirror>, NameResolver<JVariableSig>> inheritedMembersResolvers(JClassType t) {
        Pair<ShadowChainBuilder<JTypeMirror, ?>.ResolverBuilder, ShadowChainBuilder<JVariableSig, ?>.ResolverBuilder> builders =
            hidingWalkResolvers(t, t, t.getSymbol().getPackageName(), true, /* onlyStatic: */false, DIRECT_STRICT_SUPERTYPES);
        return Pair.of(builders.getLeft().build(), builders.getRight().build());
    }

    static Pair<ShadowChainBuilder<JTypeMirror, ?>.ResolverBuilder,
        ShadowChainBuilder<JVariableSig, ?>.ResolverBuilder> importOnDemandMembersResolvers(JClassType t, @NonNull String accessPackageName) {
        return hidingWalkResolvers(t, null, accessPackageName, false, /* onlyStatic: */ true, JUST_SELF /* include self members */);
    }

    private static Pair<ShadowChainBuilder<JTypeMirror, ?>.ResolverBuilder, ShadowChainBuilder<JVariableSig, ?>.ResolverBuilder> hidingWalkResolvers(JClassType t,
                                                                                                                                                     @Nullable JClassType accessType,
                                                                                                                                                     @NonNull String accessPackageName,
                                                                                                                                                     boolean accessIsSubtypeOfOwner,
                                                                                                                                                     boolean onlyStatic,
                                                                                                                                                     SuperTypesEnumerator enumerator) {
        JClassSymbol nestRoot = accessType == null ? null : accessType.getSymbol().getNestRoot();

        ShadowChainBuilder<JVariableSig, ?>.ResolverBuilder fields = SymTableFactory.VARS.new ResolverBuilder();
        ShadowChainBuilder<JTypeMirror, ?>.ResolverBuilder types = SymTableFactory.TYPES.new ResolverBuilder();

        Predicate<JVariableSig> isFieldAccessible =
            s -> filterStatic(onlyStatic, s.getSymbol())
                && isAccessibleIn(nestRoot, accessPackageName, (JFieldSymbol) s.getSymbol(), accessIsSubtypeOfOwner);
        Predicate<JClassType> isTypeAccessible =
            s -> filterStatic(onlyStatic, s.getSymbol())
                && isAccessibleIn(nestRoot, accessPackageName, s.getSymbol(), accessIsSubtypeOfOwner);

        for (JClassType next : enumerator.iterable(t)) {
            walkSelf(next, isFieldAccessible, isTypeAccessible, fields, types, HashTreePSet.empty(), HashTreePSet.empty());
        }

        return Pair.of(types, fields);
    }

    private static boolean filterStatic(boolean onlyStatic, JElementSymbol symbol) {
        return !onlyStatic || Modifier.isStatic(((JAccessibleElementSymbol) symbol).getModifiers());
    }

    private static void walkSelf(JClassType t,
                                 Predicate<? super JVariableSig> isFieldAccessible,
                                 Predicate<? super JClassType> isTypeAccessible,
                                 ShadowChainBuilder<JVariableSig, ?>.ResolverBuilder fields,
                                 ShadowChainBuilder<JTypeMirror, ?>.ResolverBuilder types,
                                 // persistent because may change in every path of the recursion
                                 final PSet<String> hiddenFields,
                                 final PSet<String> hiddenTypes) {

        // Note that it is possible that this process recurses several
        // times into the same interface (if it is reachable from several paths)
        // This is because the set of hidden declarations depends on the
        // full path, and may be different each time.
        // Profiling shows that this doesn't occur very often, and adding
        // a recursion guard is counter-productive performance-wise

        PSet<String> hiddenTypesInSup = processDeclarations(types, hiddenTypes, isTypeAccessible, t.getDeclaredClasses());
        PSet<String> hiddenFieldsInSup = processDeclarations(fields, hiddenFields, isFieldAccessible, t.getDeclaredFields());

        // depth first
        for (JClassType next : DIRECT_STRICT_SUPERTYPES.iterable(t)) {
            walkSelf(next, isFieldAccessible, isTypeAccessible, fields, types, hiddenFieldsInSup, hiddenTypesInSup);
        }
    }

    private static <S> PSet<String> processDeclarations(
        ShadowChainBuilder<? super S, ?>.ResolverBuilder builder,
        PSet<String> hidden,
        Predicate<? super S> isAccessible,
        List<? extends S> syms
    ) {
        for (S inner : syms) {
            String simpleName = builder.getSimpleName(inner);
            if (hidden.contains(simpleName)) {
                continue;
            }

            hidden = hidden.plus(simpleName);

            if (isAccessible.test(inner)) {
                builder.appendWithoutDuplicate(inner);
            }
        }
        return hidden;
    }

    /**
     * A general-purpose accessibility check, which can be used if you
     * know in advance whether the context is a supertype of the class
     * (ie, whether the sym is accessible if "protected").
     *
     * @param nestRoot Root enclosing type for the context of the reference
     * @param sym      Symbol to test
     */
    public static boolean isAccessibleIn(@NonNull JClassSymbol nestRoot,
                                         JAccessibleElementSymbol sym,
                                         boolean isOwnerASupertypeOfContext) {
        return isAccessibleIn(nestRoot, nestRoot.getPackageName(), sym, isOwnerASupertypeOfContext);
    }

    /**
     * Whether the given sym is accessible in some type T, given
     * the 'nestRoot' of T, and whether T is a subtype of the class
     * declaring 'sym'. This is a general purpose accessibility check,
     * albeit a bit low-level (but only needs subtyping to be computed once).
     */
    private static boolean isAccessibleIn(@Nullable JClassSymbol nestRoot,
                                          @NonNull String packageName,
                                          JAccessibleElementSymbol sym,
                                          boolean isOwnerASupertypeOfContext) {
        int modifiers = sym.getModifiers() & (Modifier.PUBLIC | Modifier.PROTECTED | Modifier.PRIVATE);

        switch (modifiers) {
        case Modifier.PUBLIC:
            return true;
        case Modifier.PRIVATE:
            return nestRoot != null && nestRoot.equals(sym.getEnclosingClass().getNestRoot());
        case Modifier.PROTECTED:
            if (isOwnerASupertypeOfContext) {
                return true;
            }
            // fallthrough
        case 0:
            return sym.getPackageName().equals(packageName);
        default:
            // TODO this is reachable for invalid declarations, like a private field of an interface
            throw AssertionUtil.shouldNotReachHere("private field of an interface? " + sym + ", modifiers: " + Modifier.toString(sym.getModifiers()));
        }
    }


    /**
     * Produce a name resolver that resolves member classes with the
     * given name declared or inherited by the given type. Each access
     * may perform a hierarchy traversal, but this handles hidden and
     * ambiguous declarations nicely.
     *
     * @param c      Class to search
     * @param access Context of where the declaration is referenced
     * @param name   Name of the class to find
     */
    public static NameResolver<JClassType> getMemberClassResolver(JClassType c, @NonNull String accessPackageName, @Nullable JClassSymbol access, String name) {
        return getNamedMemberResolver(c, access, accessPackageName, JClassType::getDeclaredClass, name, JClassType::getSymbol, SymTableFactory.TYPES);
    }

    public static NameResolver<FieldSig> getMemberFieldResolver(JClassType c, @NonNull String accessPackageName, @Nullable JClassSymbol access, String name) {
        return getNamedMemberResolver(c, access, accessPackageName, JClassType::getDeclaredField, name, FieldSig::getSymbol, SymTableFactory.VARS);
    }

    private static <S> NameResolver<S> getNamedMemberResolver(JClassType c,
                                                              @Nullable JClassSymbol access,
                                                              @NonNull String accessPackageName,
                                                              BiFunction<? super JClassType, String, ? extends S> getter,
                                                              String name,
                                                              Function<? super S, ? extends JAccessibleElementSymbol> symbolGetter,
                                                              ShadowChainBuilder<? super S, ?> classes) {
        S found = getter.apply(c, name);
        if (found != null) {
            // fast path, doesn't need to check accessibility, etc
            return CoreResolvers.singleton(name, found);
        }

        JClassSymbol nestRoot = access == null ? null : access.getNestRoot();
        Predicate<S> isAccessible = s -> {
            JAccessibleElementSymbol sym = symbolGetter.apply(s);
            return isAccessibleIn(nestRoot, accessPackageName, sym, isSubtype(access, sym.getEnclosingClass()));
        };

        @SuppressWarnings("unchecked")
        ShadowChainBuilder<S, ?>.ResolverBuilder builder = (ShadowChainBuilder<S, ?>.ResolverBuilder) classes.new ResolverBuilder();

        for (JClassType next : DIRECT_STRICT_SUPERTYPES.iterable(c)) {
            walkForSingleName(next, isAccessible, name, getter, builder, HashTreePSet.empty());
        }

        return builder.build();
    }

    private static boolean isSubtype(JClassSymbol sub, JClassSymbol sup) {
        return sub != null && sub.getTypeSystem().typeOf(sub, true).getAsSuper(sup) != null;
    }

    private static <S> void walkForSingleName(JClassType t,
                                              Predicate<? super S> isAccessible,
                                              String name,
                                              BiFunction<? super JClassType, String, ? extends S> getter,
                                              ShadowChainBuilder<? super S, ?>.ResolverBuilder builder,
                                              final PSet<String> hidden) {

        PSet<String> hiddenInSup = processDeclarations(builder, hidden, isAccessible, listOfNotNull(getter.apply(t, name)));

        if (!hiddenInSup.isEmpty()) {
            // found it in this branch
            // in this method the hidden set is either empty or one element only
            return;
        }

        // depth first
        for (JClassType next : DIRECT_STRICT_SUPERTYPES.iterable(t)) {
            walkForSingleName(next, isAccessible, name, getter, builder, hiddenInSup);
        }
    }

}

pmd / pmd / 277

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous