sudo-suhas / elastic-builder / 19727954794

100%

push

github

test: migrate from AVA to Vitest and remove test macros (#221)

Replace AVA test framework with Vitest and eliminate all test macros
by expanding them into explicit, self-documenting test cases. This
migration improves developer experience with watch mode, built-in
coverage reporting, and makes each test independently readable.

Key changes:

Dependencies and Configuration:
- Replace AVA with Vitest for test execution
- Remove NYC in favor of Vitest's built-in coverage (@vitest/coverage-v8)
- Remove eslint-plugin-ava and add eslint-plugin-vitest
- Create vitest.config.js with ES Modules support, parallel execution,
  and coverage configuration matching previous NYC settings
- Configure coverage to generate html, lcov, and text reports in a
  single test run

Test Migration (153 test files transformed):
- Convert all test files from AVA syntax to Vitest syntax
- Replace AVA's `t.deepEqual()` with `expect().toEqual()`
- Replace AVA's `t.truthy()` with `expect().toBeTruthy()`
- Replace AVA's `t.throws()` with `expect().toThrow()`
- Use explicit imports: `import { test, expect, describe } from 'vitest'`

Test Macro Elimination:
- Remove test/_macros.js entirely (contained 6 test macro patterns)
- Expand `setsAggType` macro into explicit aggregation type tests
- Expand `validatedCorrectly` macro into table-driven validation tests
- Expand `makeSetsOptionMacro` generated tests into explicit option tests
- Expand `illegalCall` macro into explicit error tests with toThrow()
- Expand `illegalParamType` macro into explicit TypeError tests
- All expanded tests follow table-driven patterns for maintainability

Test Utilities:
- Create test/testutil/ package for shared test helper functions
- Add type checking utilities for parameter validation
- Export all utilities from test/testutil/index.js
- Reuse existing recursiveToJSON from src/core/util.js

Package Scripts:
- Update test:src: `vitest run --coverage` (single-step execution)
- Remove report script (now redu... (continued)

1367 of 1370 branches covered (99.78%)

Branch coverage included in aggregate %.

19247 of 19252 relevant lines covered (99.97%)

10.17 hits per line