databendlabs / openraft / 19726658363

88%

Build Type

push

github

Committed by drmingdrmer

Commit Message

refactor: decouple log replication from commit index update

This commit decouples the application of log entries from the commit
index update in `handle_append_entries_request()`.

In standard Raft, AppendEntries bundles log entries and committed index
together, requiring them to be processed atomically. If separated
improperly, a follower might mistakenly believe uncommitted local log
entries are committed.

In previous commits, we associated the committed log ID with a leader
ID, making it safe to process log replication and commit index updates
independently. This refactoring prepares for a future change where the
leader will use two separate streams to replicate log entries and
committed index to followers.

Changes:
- Change `handle_append_entries()` to return `()` instead of `bool`
- Call `update_committed()` unconditionally in `handle_append_entries_request()`
- Remove outdated TODO comment

Run Details

4 of 4 new or added lines in 2 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

13769 of 14875 relevant lines covered (92.56%)

155328.45 hits per line