Qiskit / qiskit / 19713420126

88%

Build Type

push

github

Committed by web-flow

Commit Message

Add `instruction_supported` to `QkTarget`. (#14566)

* Initial: Add `instruction_supported` to `QkTarget`.
- Add variants for `reset` and `measure`.
- Add unit tests.

* Refactor: Remove `num_qubits` as an argument, use the gate's specifications.

* Docs: Add release note

* Chore: Remove unused result variable in `create_sample_target`.

* Docs: Fix docstring and release note

* Chore: Address documentation issues.

Co-authored-by: Eli Arbel <46826214+eliarbel@users.noreply.github.com>

* Chore: Fix docstring.

* Fix: Merge conflicts.

* Refactor: Streamline `qk_target_instruction_supported`.
- Accept a C originating string instead of a `QkGate` instance.
- Remove variant methods `qk_target_{measure/reset}_supported`.
- Accept an array of `QkParam` to check for parameters.
- Cleaned up and updated test case.

* Fix: Remove python dependency to check numeric value of param.
This commit removes the python dependency when checking if a float originating from the original instruction and a symbol being compared to it have the same value.

* Docs: Update release note.

* Docs: Add missing free in release note

* Apply suggestions from code review

Co-authored-by: Eli Arbel <46826214+eliarbel@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Eli Arbel <46826214+eliarbel@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Eli Arbel <46826214+eliarbel@users.noreply.github.com>

* Fix: Address review comments

* Apply suggestions from code review

Co-authored-by: Eli Arbel <46826214+eliarbel@users.noreply.github.com>

* Fix: Address more review comments

* Fix: Change `RuntimeError` to
`EqualityError`

---------

Co-authored-by: Eli Arbel <46826214+eliarbel@users.noreply.github.com>

Run Details

24 of 26 new or added lines in 2 files covered. (92.31%)

23 existing lines in 4 files now uncovered.

94527 of 106917 relevant lines covered (88.41%)

1197434.03 hits per line