mozilla-releng / balrog / #5028

90%

main: 89%

push

circleci

Fix axios interceptors leak by ejecting old ones when adding new ones (#3577)

When either `getAccessTokenSilently` or `getIdTokenClaims` changes, we
would install axios interceptors without removing the previous ones.
This happens every time we login/logout and they stacked on each other,
leading to us getting the (thankfully cached) token X times per request.

While I don't think that this causes any real issue, it's obviously
wrong and is an easy fix since react allows returning a cleanup function
from `useEffect` which gets called when a dependency changes (before
calling the callback again).

2167 of 2544 branches covered (85.18%)

Branch coverage included in aggregate %.

5722 of 6218 relevant lines covered (92.02%)

0.92 hits per line