kubevirt / hyperconverged-cluster-operator / 19672035846

76%

push

github

CNV-73300: Remove old NetworkPolicies on Upgrade (#3888)

* Remove old NetworkPolicies on Upgrade

In order to make sure we can safely deploy network policies by OLM,
we must have a way to clean them up if needed.

We label the OLM deployed network policies with
`np.kubevirt.io/version`, with the value of the CSV-Version.

During upgrade, HCO will remove any NetworkPolicy that is in the
installation namespace, and has the np.kubevirt.io/version, with the
value not equal to the HCO version (taken from the
`HCO_KV_IO_VERSION` environment variable).

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* Split the upgrade unit tests out of hyperconverged_controller_test.go

The hyperconverged_controller_test.go file is too large to maintain.
This commit takes out all the upgrade related tests into a new dedicated
file, upgrade_test.go.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

---------

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

21 of 28 new or added lines in 2 files covered. (75.0%)

8008 of 10417 relevant lines covered (76.87%)

1.84 hits per line