Qiskit / qiskit / 19669047437

88%

Build Type

push

github

Committed by web-flow

Commit Message

Add `qk_circuit_to_dag` and `qk_dag_to_circuit` to the C API (#15247)

* Add qk_circuit_to_dag and qk_dag_to_circuit

This commit adds dag to circuit and circuit to dag converters
to the C API. The C API function signatures follow those of the
corresponding Python functions.

* Normalize error message

* Fix c testing

Moved the testing functions to the proper place following their rename
in the C API itself.

* Apply suggestion from @jakelishman

Co-authored-by: Jake Lishman <jake@binhbar.com>

* Apply suggestion from @jakelishman

Co-authored-by: Jake Lishman <jake@binhbar.com>

* Apply suggestion from @jakelishman

Co-authored-by: Jake Lishman <jake@binhbar.com>

* Address review comments

* Remove copy_operations
* Fix usage of `unsafe`
* Add Rust test to `circuit_to_dag`
* Update documentation

* Fix miri failure

Free the DAGCircuit created by qk_circuit_to_dag

* Fix cargo fmt --check

* Address review comments

* Compare instruction counts in the dag/circuit converters tests
* Update function documentation

* Address review comments

* Remove support for qubit_order and clbit_order in `qk_circuit_to_dag`
* Minor documentation tweaks

* Align with code example indent convention in the file

* Apply cargo fmt

* Add comment on ownership of inputs

---------

Co-authored-by: Jake Lishman <jake@binhbar.com>
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>

Run Details

12 of 12 new or added lines in 2 files covered. (100.0%)

23 existing lines in 3 files now uncovered.

94331 of 106926 relevant lines covered (88.22%)

1194014.37 hits per line