immerjs / immer / 19609458487

43%

Build Type

push

github

Committed by web-flow

Commit Message

perf: Rewrite finalization system to use a callback approach instead of tree traversal (#1183)

BREAKING CHANGE: enable loose iteration by default

* Simplify some iteration checks
* Allow passing type to get/set utils to skip archetype lookup
* Convert assigned_ to Map
* Enable loose iteration
* Replace recursive tree finalization with targeted callbacks

Ported Mutative's "finalization callback" approach as a more targeted and performant implementation for finalization compared to the existing recursive tree traversal approach:

- Added cleanup callbacks for each draft that's created
- Added callbacks to handle root drafts, assigned values, and recursing
  inside of plain values
- Updated state creation to return [draft, state] to avoid a lookup
- Rewrote patch generation system to work with callbacks instead of
  during tree traversal

* Update self-reference test with new behavior
* Apply code review suggestions
* Byte-shave scopes and patch plugin usage
* Inline finalizeAssigned
* Move fixPotentialSetContents to plugin
* Byte-shave typeof utils
* Byte-shave Object references
* Byte-shave field names and arrow functions

Run Details

606 of 636 branches covered (95.28%)

Branch coverage included in aggregate %.

434 of 448 new or added lines in 10 files covered. (96.88%)

2 existing lines in 1 file now uncovered.

1468 of 3973 relevant lines covered (36.95%)

1416.04 hits per line