migration-script-runner / msr-core / 5dcd6ff6-e5a3-4ed0-a83c-10c7f4c99c34

100%

Build Type

push

circleci

Committed by Vova Lavrynovych

Commit Message

#43: Fix backup file renaming bug in BackupService

Fixed no-op file rename operation in getFileName() that was renaming files to themselves.

Bug: Called prepareFilePath() twice with identical arguments, resulting in fs.renameSync(path, path)

Fix: Archive existing backup files with unique timestamp suffix (.old-<timestamp>) before creating new backup

Changes:
- BackupService.getFileName(): Now properly archives old backups
- Updated test to verify old path ≠ new path
- Added JSDoc documentation
- 185 tests passing, 100% coverage maintained

Prevents data loss from backup file collisions.

Run Details

71 of 71 branches covered (100.0%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

330 of 330 relevant lines covered (100.0%)

54.69 hits per line