rm-hull / jasengo / 19603216439

81%

push

github

refactor: Implement generic buffer abstractions (#9)

* feat: Implement generic buffer abstractions

Introduces the `internal/buffer` package to provide generic data
structures for buffering elements.

This includes:
* `Buffer[T]` interface defining core buffer operations.
* `RingBuffer[T]` for fixed-size circular buffers.
* `UnboundedBuffer[T]` for grow-only buffers.

The parser's `runeReader` implementation is refactored to utilize
these new buffers, choosing between `RingBuffer` (when a limit is
set) or `UnboundedBuffer` (when the limit is zero). This simplifies
the internal buffer management logic in `reader.go`.

* Update internal/buffer/ring_buffer.go

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* perf: Optimize RingBuffer.Slice using copy()

Switches the implementation of `RingBuffer.Slice` from
iterative appending to using `copy()` operations.

This provides substantial performance improvements when
reading large segments of the buffer by leveraging
optimized memory movement primitives. The logic now
handles contiguous and wrap-around copies directly.

* refactor: Simplify runeReader struct fields

Removes the unused `limit` field from `runeReader` as it was
only consumed during initialization in `NewReader`.

Additionally, renames `bufferOffset` to `offset` for brevity
and clarity across the implementation.

* refactor: Remove extra blank line in `ring_buffer.go`

Removes a redundant blank line after the `NewRingBuffer` function
definition for improved code clarity and conventional formatting.

* refactor: Move absolute index tracking to Buffer

The responsibility for tracking the absolute index of the
logical start (tail) of the buffer window has been moved
from the `runeReader` to the `Buffer` implementation via
the new `Base()` method.

This refactoring:
*   Removes manual offset tracking from `runeReader`.
*   Removes `IsFull()` from the `Buffer` interface.
*   Ensures buffer logic... (continued)

33 of 33 new or added lines in 1 file covered. (100.0%)

390 of 502 relevant lines covered (77.69%)

0.9 hits per line