FlexMeasures / flexmeasures / 19587510610

74%

push

github

Fix/default commitment prices (#1793)

* fix: unnamed commitments should not pass validation

Signed-off-by: F.N. Claessen <felix@seita.nl>

* feat: also raise InfeasibleProblemException in case of an infeasibleOrUnbounded termination condition, to allow triggering the FallbackStorageScheduler

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: expected error message in test

Signed-off-by: F.N. Claessen <felix@seita.nl>

* docs: changelog entry

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: use already defined timing variables

Signed-off-by: F.N. Claessen <felix@seita.nl>

* refactor: pass belief_time

Signed-off-by: F.N. Claessen <felix@seita.nl>

* refactor: move timing_kwargs out of loop

Signed-off-by: F.N. Claessen <felix@seita.nl>

* refactor: move timing_kwargs into function signature

Signed-off-by: F.N. Claessen <felix@seita.nl>

* refactor: move price_unit out of loop

Signed-off-by: F.N. Claessen <felix@seita.nl>

* refactor: reuse price_unit variable

Signed-off-by: F.N. Claessen <felix@seita.nl>

* feat: test case that leads to an infeasibleOrUnbounded termination status

Signed-off-by: F.N. Claessen <felix@seita.nl>

* docs: add inline comment

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: add big-M bounds on commitment deviations

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: compute big-M for commitment deviations

Signed-off-by: F.N. Claessen <felix@seita.nl>

* dev: improve inspection capabilities of device_scheduler results in test

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: only use extra binary variable if cost curve is not convex

Signed-off-by: F.N. Claessen <felix@seita.nl>

* chore: increment StorageScheduler version

Signed-off-by: F.N. Claessen <felix@seita.nl>

* docs: clarify a little bit what the role of the Big-M variables are

Signed-off-by: F.N. Claessen <felix@seita.nl>

---------

Signed-off-by: F.N. Claessen <felix@seita.nl>

1375 of 2014 branches covered (68.27%)

Branch coverage included in aggregate %.

33 of 33 new or added lines in 3 files covered. (100.0%)

10105 of 13612 relevant lines covered (74.24%)

5.94 hits per line