pantsbuild / pants / 19581575426

push

github

Java fix bug with inner class inference (#22889)

In Java, it's perfectly valid for a class in one package to reference
another class in the same package without importing it. The current Java
dependency inference code works fine for top level references, but
doesn't work when inner classes are involved. Suppose we have class A in
A.java and class B in B.java with a static inner class InnerB. All of
these classes are in the same package. A uses B.InnerB, but doesn't
explicitly import B. This is valid practice in Java, but with our Pants
Java dependency inference logic, the backend won't figure out on its own
that A.java depends on B.java without an explicit dependency reference.

This PR contains the changes for fixing this bug as seen in #22817 I've
split it into its own PR to make things easier to review and land

21 of 27 new or added lines in 2 files covered. (77.78%)

78406 of 97646 relevant lines covered (80.3%)

3.36 hits per line