Qiskit / qiskit / 19578967555

88%

Build Type

push

github

Committed by web-flow

Commit Message

Add `UnitaryGate` handling to `QkDag` C API (#15363)

* Add `UnitaryGate` handling to `QkDag` C API

This adds methods to add and retrieve unitary matrices from `QkDag`.
We likely need something similar to retrieve the matrices from
`QkCircuit` as well at some point.

This commit uses copy-out semantics for the arrays to ensure that the
output is always row-major, but it's quite possible that we might want
an alternative method that fills in some sort of

```c
struct QkMatView {
    QkComplex64 *mat,
    size_t shape[2];
    size_t stride[2];
}
```

by just populating the pointer, and the metadata, so it's much cheaper.
We'd need to include the strides because Qiskit internally already can't
guarantee its matrices are contiguous, and the `OneQ`/`TwoQ` variants
are col-major while the `NDArray` variant is (usually) row-major.

* Correct comment on null pointers

Run Details

86 of 88 new or added lines in 2 files covered. (97.73%)

11 existing lines in 2 files now uncovered.

94387 of 106976 relevant lines covered (88.23%)

1147211.03 hits per line