optimizely / go-sdk / 19575001294

92%

push

github

[FSSDK-11552] Add holdout support and refactor decision logic (#422)

* add holdouts service and logic

* fix: resolve range variable address bug in holdout loop (CWE-118)

- Changed loop from 'for _, holdout := range holdouts' to 'for i := range holdouts'
- Created proper pointer 'holdout := &holdouts[i]' to avoid address-of-iteration-variable issue
- This fixes the security warning where all iterations would point to the same memory location
- All tests passing

Resolves Prisma Cloud security scan: Incorrect access of indexable resource

* feat: Complete holdout implementation with parsing, mapping, and tests

- Implemented holdout parsing from datafile with global/specific/exclusion logic
- Added MapHoldouts() to process holdout relationships with feature flags
- Implemented GetHoldoutsForFlag() to retrieve applicable holdouts per flag
- Fixed bucketer initialization to use pointer (interface value)
- Created comprehensive unit tests for HoldoutService (11 test cases)
- Added integration test with real bucketer and evaluator
- Added GetHoldoutsForFlag() mock method to helpers_test.go

All tests passing (decision and config packages)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* test: Add comprehensive tests for holdout implementation and fix linting

- Added 3 unit tests for GetHoldoutsForFlag() in config_test.go
- Created holdout_test.go with 7 comprehensive mapper tests:
  - Empty holdouts
  - Global holdouts with exclusions
  - Specific holdouts with inclusions
  - Non-running holdouts filtering
  - Mixed global and specific holdouts
  - Audience conditions mapping
  - Variations and traffic allocation mapping
- Fixed govet shadow linting error in holdout_service.go line 105

All tests passing. Improves code coverage for new holdout functionality.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* fixed holdouts pr... (continued)

180 of 192 new or added lines in 4 files covered. (93.75%)

5616 of 6109 relevant lines covered (91.93%)

8395.08 hits per line