tari-project / tari / 19571297598

61%

Build Type

push

github

Committed by web-flow

Commit Message

fix: store completed transactions with corresponding sent_output_hash (#7595)

Description
---

Updates `send_many_one_sided_transactions` so that completed
transactions, which are stored for each recipient, have a single
corresponding output hash.

This fix simplifies the code, as well as fixes a possible bug of how
corresponding outputs where found. They were looked up by `value`, which
would yield incorrect results, if multiple payments with the same value
would be sent using this function.

I inspected the **Transaction Builder**, its `add_stealth_recipient()`
and `build()`.
The order of `sent_output_hashes` and `sent_outputs` is exactly the same
as they were originally added in transaction builder.

Motivation and Context
---

GRPC `transfer` call has a feature (enabled by setting `single_tx=true`)
to send a single transaction to multiple recipients.
But when the resulting transaction is queried for each recipient, it
returned all `sent_output_hashes` instead of the one, which belongs to
that particular recipient.

This change makes a fix, so that `sent_output_hashes` will always
contain a single entry with corresponding output hash.

How Has This Been Tested?
---

What process can a PR reviewer use to test or verify this change?
---

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Refactor**
* Improved multi-recipient one-side... (continued)

Run Details

0 of 29 new or added lines in 1 file covered. (0.0%)

25 existing lines in 8 files now uncovered.

70439 of 114774 relevant lines covered (61.37%)

303323.6 hits per line