• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

tari-project / tari / 19571297598
61%

Build:
DEFAULT BRANCH: development
Ran 21 Nov 2025 03:03PM UTC
Jobs 1
Files 704
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

21 Nov 2025 01:01PM UTC coverage: 61.372% (+0.01%) from 61.362%
19571297598

push

github

web-flow
fix: store completed transactions with corresponding sent_output_hash (#7595)

Description
---

Updates `send_many_one_sided_transactions` so that completed
transactions, which are stored for each recipient, have a single
corresponding output hash.

This fix simplifies the code, as well as fixes a possible bug of how
corresponding outputs where found. They were looked up by `value`, which
would yield incorrect results, if multiple payments with the same value
would be sent using this function.

I inspected the **Transaction Builder**, its `add_stealth_recipient()`
and `build()`.
The order of `sent_output_hashes` and `sent_outputs` is exactly the same
as they were originally added in transaction builder.

Motivation and Context
---

GRPC `transfer` call has a feature (enabled by setting `single_tx=true`)
to send a single transaction to multiple recipients.
But when the resulting transaction is queried for each recipient, it
returned all `sent_output_hashes` instead of the one, which belongs to
that particular recipient.

This change makes a fix, so that `sent_output_hashes` will always
contain a single entry with corresponding output hash.

How Has This Been Tested?
---

What process can a PR reviewer use to test or verify this change?
---

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Refactor**
* Improved multi-recipient one-side... (continued)

0 of 29 new or added lines in 1 file covered. (0.0%)

25 existing lines in 8 files now uncovered.

70439 of 114774 relevant lines covered (61.37%)

303323.6 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
29
0.0
0.0% base_layer/wallet/src/transaction_service/service.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
84.05
-0.23% base_layer/p2p/src/services/liveness/service.rs
1
0.0
0.0% base_layer/wallet/src/transaction_service/service.rs
2
82.99
-0.69% comms/core/src/connection_manager/manager.rs
3
57.14
-1.0% base_layer/core/src/base_node/sync/block_sync/synchronizer.rs
3
67.56
1.78% comms/core/src/protocol/messaging/protocol.rs
3
81.36
-1.69% comms/core/src/protocol/rpc/status.rs
4
79.55
-0.82% comms/core/src/noise/socket.rs
8
56.8
-0.69% comms/core/src/connectivity/manager.rs
Jobs
ID Job ID Ran Files Coverage
1 19571297598.1 21 Nov 2025 03:03PM UTC 704
61.37
GitHub Action Run
Source Files on build 19571297598
  • Tree
  • List 704
  • Changed 13
  • Source Changed 1
  • Coverage Changed 13
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #19571297598
  • 362c2f51 on github
  • Prev Build on development (#19501614580)
  • Next Build on development (#19627520782)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc