babelfish-for-postgresql / babelfish_extensions / 19568509781

77%

push

github

Fix string types to sqlvariant conversion with query based initialization. (#4198)

This commit fixes an issue where implicit conversions from string types to
sqlvariant type were handled incorrectly during query-based initialization.

The problem occurred with SQL queries containing implicit conversions from
string types (specifically those starting with 'SELECT') during the
initialization process of sqlvariant types. These conversions were not being
processed correctly, leading to potential errors or incorrect behavior.

The root cause was about wrong calculation of the data's length in
'TdsSendTypeSqlvariant' function. The correct modifications have been done for
char, varchar, nchar, nvarchar and binary types.

Issues Resolved
https://github.com/babelfish-for-postgresql/babelfish_extensions/issues/4129
[BABEL-6215]

Author: Berkay <berkayozkarhan>
Reviewed-by: Tanzeel Khan <tzlkhan@amazon.com>
Reviewed-by: Pranav Jain <pranav23iitd@gmail.com>

5 of 5 new or added lines in 1 file covered. (100.0%)

51975 of 67720 relevant lines covered (76.75%)

381027.39 hits per line