DANS-KNAW / dataverse / #199
24%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 992
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 24.037% (+0.2%) from 23.803%
#199

push

github

web-flow 
11744 CORS: echo request Origin + add Vary (#11745)

* 11744: CORS: echo request Origin and add Vary: Origin; sanitize CSV lists; prefer comma-separated origins; rely on JVM options/MicroProfile only; add tests and release notes

* Centralize CSV parsing (CsvUtil) + CORS origin echo & Vary header improvements

* Make CORS origin list optional in CorsFilter initialization

* Refactor GlobusOverlayAccessIO and CsvUtil for improved endpoint handling and CSV parsing

* updated release note and comments

* test fixes

* Clarify CORS requirements for browser-based external tools in documentation

* Update CORS documentation to clarify configuration requirements and deprecate legacy settings

* Remove unused CSV lookup methods

* Update JvmSettings documentation to clarify CSV list return types

* Refactor doc structure for improved readability and maintainability

* wording

* Removed deprecated (and removed from code) AllowCors setting from doc

* Fix formatting inconsistencies in dataset management documentation

* rename: CsvUtil -> ListSplitUtil

* Refactor CSV list lookup methods to join array elements before splitting

* Rename CSV list lookup methods to use 'lookupSplittedList' for consistency

* revert whitespace changes done by automated formatting tool

* revert whitespace-only changes done by automatic tool

* code cleanup

* code cleanup

* revert whitespace changes done by automated formatting tool

* revert whitespace changes done by automated formatting tool

* revert whitespace changes done by automated formatting tool

* revert whitespace changes done by automated formatting tool

* remove legacy dependency on SettingsServiceBean in CorsFilterTest

* refactor: replace Arrays.stream with ListSplitUtil.split in CorsFilter

* refactor: replace ListSplitUtil.split with Arrays.stream for list processing in JvmSettings

* Enhance JvmSettings: Add trimming options for lookupSplittedList methods to handle whitespace in tokenized values

---------

... (continued)

68 of 121 new or added lines in 20 files covered. (56.2%)

2494 existing lines in 27 files now uncovered.

22144 of 92123 relevant lines covered (24.04%)

0.24 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
0.0
 0.0% src/main/java/edu/harvard/iq/dataverse/api/Admin.java
1
0.0
 0.0% src/main/java/edu/harvard/iq/dataverse/workflow/internalspi/LDNAnnounceDatasetVersionStep.java
2
0.14
 0.0% src/main/java/edu/harvard/iq/dataverse/api/Datasets.java
2
7.41
 0.0% src/main/java/edu/harvard/iq/dataverse/dataaccess/GlobusAccessibleStore.java
2
81.82
 src/main/java/edu/harvard/iq/dataverse/util/ListSplitUtil.java
3
32.92
 -0.42% src/main/java/edu/harvard/iq/dataverse/dataaccess/GlobusOverlayAccessIO.java
3
43.11
 0.0% src/main/java/edu/harvard/iq/dataverse/dataaccess/RemoteOverlayAccessIO.java
3
1.01
 0.0% src/main/java/edu/harvard/iq/dataverse/pidproviders/PidProviderFactoryBean.java
3
0.0
 0.0% src/main/java/edu/harvard/iq/dataverse/util/CSLUtil.java
4
30.05
 0.0% src/main/java/edu/harvard/iq/dataverse/DatasetFieldServiceBean.java
5
0.0
 0.0% src/main/java/edu/harvard/iq/dataverse/batch/jobs/importer/filesystem/FileRecordReader.java
6
48.67
 -0.19% src/main/java/edu/harvard/iq/dataverse/FileMetadata.java
7
25.52
 6.34% src/main/java/edu/harvard/iq/dataverse/util/SystemConfig.java
11
0.28
 -0.0% src/main/java/edu/harvard/iq/dataverse/SettingsWrapper.java

Uncovered Existing Lines

Lines Coverage ∆ File
1
30.05
 0.0% src/main/java/edu/harvard/iq/dataverse/DatasetFieldServiceBean.java
1
48.67
 -0.19% src/main/java/edu/harvard/iq/dataverse/FileMetadata.java
1
86.36
 0.65% src/main/java/edu/harvard/iq/dataverse/util/file/BagItFileHandlerFactory.java
2
0.28
 -0.0% src/main/java/edu/harvard/iq/dataverse/SettingsWrapper.java
3
1.01
 0.0% src/main/java/edu/harvard/iq/dataverse/pidproviders/PidProviderFactoryBean.java
5
0.0
 0.0% src/main/java/edu/harvard/iq/dataverse/flyway/StartupFlywayMigrator.java
5
86.36
 1.99% src/main/java/edu/harvard/iq/dataverse/util/json/JsonUtil.java
8
66.67
 66.67% src/main/java/edu/harvard/iq/dataverse/settings/Setting.java
11
0.0
 0.0% src/main/java/edu/harvard/iq/dataverse/api/Workflows.java
12
45.16
 -0.09% src/main/java/edu/harvard/iq/dataverse/util/json/JsonPrinter.java
18
4.45
 -0.07% src/main/java/edu/harvard/iq/dataverse/api/Dataverses.java
19
0.0
 0.0% src/main/java/edu/harvard/iq/dataverse/engine/command/impl/LocalSubmitToArchiveCommand.java
30
0.0
 0.0% src/main/java/edu/harvard/iq/dataverse/api/BuiltinUsers.java
32
0.0
 0.0% src/main/java/edu/harvard/iq/dataverse/engine/command/impl/GoogleCloudSubmitToArchiveCommand.java
36
0.0
 0.0% src/main/java/edu/harvard/iq/dataverse/api/WorkflowsAdmin.java
45
2.97
 0.97% src/main/java/edu/harvard/iq/dataverse/engine/command/impl/S3SubmitToArchiveCommand.java
45
23.62
 -0.97% src/main/java/edu/harvard/iq/dataverse/pidproviders/doi/datacite/DOIDataCiteRegisterService.java
47
0.0
 0.0% src/main/java/edu/harvard/iq/dataverse/workflow/internalspi/LDNAnnounceDatasetVersionStep.java
49
0.0
 0.0% src/main/java/edu/harvard/iq/dataverse/engine/command/impl/DuraCloudSubmitToArchiveCommand.java
58
5.03
 -0.06% src/main/java/edu/harvard/iq/dataverse/pidproviders/doi/datacite/DataCiteDOIProvider.java
67
4.97
 0.53% src/main/java/edu/harvard/iq/dataverse/engine/command/impl/DRSSubmitToArchiveCommand.java
74
8.7
 -3.5% src/main/java/edu/harvard/iq/dataverse/pidproviders/doi/datacite/DataCiteRESTfullClient.java
133
60.61
 8.49% src/main/java/edu/harvard/iq/dataverse/settings/SettingsServiceBean.java
224
25.52
 6.34% src/main/java/edu/harvard/iq/dataverse/util/SystemConfig.java
226
0.0
 0.0% src/main/java/edu/harvard/iq/dataverse/util/bagit/BagGenerator.java
646
0.0
 0.0% src/main/java/edu/harvard/iq/dataverse/api/Admin.java
696
4.9
 4.9% src/main/java/edu/harvard/iq/dataverse/EditDatafilesPage.java
Jobs
ID Job ID Ran Files Coverage
1 #199.1 992
24.04
Source Files on build #199