pulibrary / bibdata / e91ba3db-768a-4c4b-8d60-ec1d274a4fcc

90%

push

circleci

Add frozen_string_literals comments to marc_to_solr files that are compatible with them (#2979)

We don't have the relevant rubocop check enabled, so many files are missing
this magic comment.

This does make MarcBreaker slightly faster, although indexing a full file
takes about the same amount of time.  I checked MarcBreaker's performance
with the following microbenchmark in `rails c`:

```
record = MARC::XMLReader.new(Rails.root.join('spec/fixtures/marc_to_solr/9914141453506421.mrx').to_s).first
Benchmark.ips { it.report { MarcBreaker.break(record) } }
```

Before:
```
Warming up --------------------------------------
                       472.000 i/100ms
Calculating -------------------------------------
                          4.705k (± 1.2%) i/s  (212.53 μs/i) -     23.600k in   5.016528s
```

After:
```
Warming up --------------------------------------
                       512.000 i/100ms
Calculating -------------------------------------
                          5.178k (± 1.4%) i/s  (193.11 μs/i) -     26.112k in   5.043372s
```

2 of 2 new or added lines in 1 file covered. (100.0%)

9019 of 10076 relevant lines covered (89.51%)

360.59 hits per line