tarantool
/
tarantool
/
19540281272
88%
master: 88%
master: 88%
|
Ran
|
Jobs
1
|
Files
519
|
Run time
2min
|
Badge
Embed ▾
README BADGES
|
coverage: 87.577% (-0.002%) from 87.579%
push
github
sergepetrenkolimbo: make txn_limbo_confirm nop during fencing Before this patch a synchronous transaction could be confirmed when user lowered `replication_synchro_quorum` while limbo is in the frozen state. It could lead to the next situation: 1) server1 loses a quorum of connections and its limbo goes into the frozen state. 2) The new elected master rollbacks a non-confirmed synchronous transaction. 3) On the old master we lower `replication_synchro_quorum` to 1. Our synchronous transaction is confirmed because our node can collect sufficient number of acks. As a result, we have inconsistent state in the replicaset because on the old master we have a confirmed transaction but on the new master we have a rolledbacked transaction. Now, we fix this issue by returning from the `txn_limbo_confirm` when `txn_limbo_is_frozen` is true. It can help us to make the `txn_limbo_confirm` - nop and not confirm synchronous transactions. Needed for tarantool#11574 NO_DOC=bugfix NO_CHANGELOG=<not released> (cherry picked from commit 51999396d)
69152 of 116565 branches covered (59.32%)
2 of 2 new or added lines in 1 file covered. (100.0%)
223 existing lines in 18 files now uncovered.103979 of 118729 relevant lines covered (87.58%)
1379063.15 hits per line
Uncovered Existing Lines
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 1 |
88.27 |
-0.62% | src/box/engine.c |
| 1 |
95.31 |
-1.56% | src/box/engine.h |
| 1 |
95.72 |
-0.12% | src/box/replication.cc |
| 1 |
90.14 |
-0.08% | src/box/vy_log.c |
| 1 |
92.92 |
-0.01% | src/lib/core/fiber.c |
| 1 |
96.1 |
-0.05% | src/lib/salad/bps_tree.h |
| 2 |
94.25 |
-0.29% | src/box/memtx_space.c |
| 2 |
92.55 |
0.0% | src/box/vinyl.c |
| 2 |
95.21 |
-1.06% | src/box/vy_range.c |
| 2 |
89.34 |
-0.12% | src/box/xrow.c |
| 2 |
85.71 |
-9.52% | src/lib/core/tt_sigaction.c |
| 2 |
22.62 |
-0.04% | src/lib/uri/uri_parser.c |
| 3 |
90.58 |
-0.15% | src/box/applier.cc |
| 3 |
84.24 |
-0.1% | src/box/xlog.c |
| 4 |
81.82 |
-12.12% | src/lua/minifio.c |
| 6 |
95.2 |
-1.25% | src/box/vy_read_iterator.c |
| 22 |
97.28 |
0.0% | src/box/lua/net_box.c |
| 167 |
91.37 |
0.08% | src/box/box.cc |
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 19540281272.1 | 519 |
87.58 |
GitHub Action Run |
