pantsbuild / pants / 19529437518

coverage: 78.884% (-1.4%) from 80.302%
19529437518

push

github

web-flow 
nfpm.native_libs: Add RPM package depends from packaged pex_binaries (#22899)

## PR Series Overview

This is the second in a series of PRs that introduces a new backend:
`pants.backend.npm.native_libs`
Initially, the backend will be available as:
`pants.backend.experimental.nfpm.native_libs`

I proposed this new backend (originally named `bindeps`) in discussion
#22396.

This backend will inspect ELF bin/lib files (like `lib*.so`) in packaged
contents (for this PR series, only in `pex_binary` targets) to identify
package dependency metadata and inject that metadata on the relevant
`nfpm_deb_package` or `nfpm_rpm_package` targets. Effectively, it will
provide an approximation of these native packager features:
- `rpm`: `rpmdeps` + `elfdeps`
- `deb`: `dh_shlibdeps` + `dpkg-shlibdeps` (These substitute
`${shlibs:Depends}` in debian control files have)

### Goal: Host-agnostic package builds

This pants backend is designed to be host-agnostic, like
[nFPM](https://nfpm.goreleaser.com/).

Native packaging tools are often restricted to a single release of a
single distro. Unlike native package builders, this new pants backend
does not use any of those distro-specific or distro-release-specific
utilities or local package databases. This new backend should be able to
run (help with building deb and rpm packages) anywhere that pants can
run (MacOS, rpm linux distros, deb linux distros, other linux distros,
docker, ...).

### Previous PRs in series

- #22873

## PR Overview

This PR adds rules in `nfpm.native_libs` to add package dependency
metadata to `nfpm_rpm_package`. The 2 new rules are:

- `inject_native_libs_dependencies_in_package_fields`:

    - An implementation of the polymorphic rule `inject_nfpm_package_fields`.
      This rule is low priority (`priority = 2`) so that in-repo plugins can
      override/augment what it injects. (See #22864)

    - Rule logic overview:
        - find any pex_binaries that will be packaged in an `nfpm_rpm_package`
   ... (continued)

96 of 118 new or added lines in 3 files covered. (81.36%)

910 existing lines in 53 files now uncovered.

73897 of 93678 relevant lines covered (78.88%)

3.21 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

22.22
/src/python/pants/bsp/utils.py
1 
# Copyright 2022 Pants project contributors (see CONTRIBUTORS.md).
2 
# Licensed under the Apache License, Version 2.0 (see LICENSE).
3 









4



from __future__ import annotations




1✔





5












6



from typing import Any




1✔





7












8



from pants.util.frozendict import FrozenDict




1✔





9












10












11



def freeze_json(item: Any) -> Any:




1✔






UNCOV

12



    if item is None:




×







13



        return None




×








UNCOV

14



    elif isinstance(item, list) or isinstance(item, tuple):




×








UNCOV

15



        return tuple(freeze_json(x) for x in item)




×








UNCOV

16



    elif isinstance(item, dict):




×








UNCOV

17



        result = {}




×








UNCOV

18



        for k, v in item.items():




×








UNCOV

19



            if not isinstance(k, str):




×







20



                raise AssertionError("Got non-`str` key for _freeze.")




×








UNCOV

21



            result[k] = freeze_json(v)




×








UNCOV

22



        return FrozenDict(result)




×








UNCOV

23



    elif isinstance(item, str) or isinstance(item, int) or isinstance(item, float):




×








UNCOV

24



        return item




×







25



    else:










26



        raise AssertionError(f"Unsupported value type for _freeze: {type(item)}")




×





















    

  • 

    •