pantsbuild / pants / 19529437518

coverage: 78.884% (-1.4%) from 80.302%
19529437518

push

github

web-flow 
nfpm.native_libs: Add RPM package depends from packaged pex_binaries (#22899)

## PR Series Overview

This is the second in a series of PRs that introduces a new backend:
`pants.backend.npm.native_libs`
Initially, the backend will be available as:
`pants.backend.experimental.nfpm.native_libs`

I proposed this new backend (originally named `bindeps`) in discussion
#22396.

This backend will inspect ELF bin/lib files (like `lib*.so`) in packaged
contents (for this PR series, only in `pex_binary` targets) to identify
package dependency metadata and inject that metadata on the relevant
`nfpm_deb_package` or `nfpm_rpm_package` targets. Effectively, it will
provide an approximation of these native packager features:
- `rpm`: `rpmdeps` + `elfdeps`
- `deb`: `dh_shlibdeps` + `dpkg-shlibdeps` (These substitute
`${shlibs:Depends}` in debian control files have)

### Goal: Host-agnostic package builds

This pants backend is designed to be host-agnostic, like
[nFPM](https://nfpm.goreleaser.com/).

Native packaging tools are often restricted to a single release of a
single distro. Unlike native package builders, this new pants backend
does not use any of those distro-specific or distro-release-specific
utilities or local package databases. This new backend should be able to
run (help with building deb and rpm packages) anywhere that pants can
run (MacOS, rpm linux distros, deb linux distros, other linux distros,
docker, ...).

### Previous PRs in series

- #22873

## PR Overview

This PR adds rules in `nfpm.native_libs` to add package dependency
metadata to `nfpm_rpm_package`. The 2 new rules are:

- `inject_native_libs_dependencies_in_package_fields`:

    - An implementation of the polymorphic rule `inject_nfpm_package_fields`.
      This rule is low priority (`priority = 2`) so that in-repo plugins can
      override/augment what it injects. (See #22864)

    - Rule logic overview:
        - find any pex_binaries that will be packaged in an `nfpm_rpm_package`
   ... (continued)

96 of 118 new or added lines in 3 files covered. (81.36%)

910 existing lines in 53 files now uncovered.

73897 of 93678 relevant lines covered (78.88%)

3.21 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

90.48
/src/python/pants/backend/go/util_rules/link_defs.py
1 
# Copyright 2023 Pants project contributors (see CONTRIBUTORS.md).
2 
# Licensed under the Apache License, Version 2.0 (see LICENSE).
3 
from __future__ import annotations
10✔
4 









5



from dataclasses import dataclass




10✔





6












7



from pants.backend.go.util_rules.build_opts import GoBuildOptions




10✔





8



from pants.engine.environment import EnvironmentName




10✔





9



from pants.engine.internals.native_engine import Digest




10✔





10



from pants.engine.rules import collect_rules, rule




10✔





11



from pants.engine.unions import union




10✔





12



from pants.util.frozendict import FrozenDict




10✔





13












14












15



@union(in_scope_types=[EnvironmentName])




10✔





16



@dataclass(frozen=True)




10✔





17



class ImplicitLinkerDependenciesHook:




10✔





18



    build_opts: GoBuildOptions




10✔





19












20












21



@dataclass(frozen=True)




10✔





22



class ImplicitLinkerDependencies:




10✔





23



    digest: Digest




10✔





24



    import_paths_to_pkg_a_files: FrozenDict[str, str]




10✔





25












26












27



@rule(polymorphic=True)




10✔





28



async def get_implicit_linker_dependencies(




10✔





29



    req: ImplicitLinkerDependenciesHook, env_name: EnvironmentName










30



) -> ImplicitLinkerDependencies:










31



    raise NotImplementedError()




×







32












33












34



def rules():




10✔






UNCOV

35



    return collect_rules()




×





















    

  • 

    •