future-architect / uroborosql / #934

91%

push

Fix SQL Server batch insert failure with IDENTITY columns (#376)

* Initial plan

* Add supportsBatchGeneratedKeys() to Dialect and implement fix for SQL Server

Co-authored-by: HidekiSugimoto189 <21981922+HidekiSugimoto189@users.noreply.github.com>

* Add test for supportsBatchGeneratedKeys() in MsSqlDialect

Co-authored-by: HidekiSugimoto189 <21981922+HidekiSugimoto189@users.noreply.github.com>

* Address PR feedback: improve batch operation check and add tests

- Replace fragile string matching with explicit SqlKind comparison
- Add batch insert tests to SqlApiTest for IDENTITY column support
- Tests verify that batch inserts work on all databases including SQL Server

Co-authored-by: HidekiSugimoto189 <21981922+HidekiSugimoto189@users.noreply.github.com>

* Add assertion to verify productId consistency when batch generated keys are supported

- When supportsBatchGeneratedKeys() returns true, verify that returnedProducts and insertedProducts have matching productIds
- This ensures the returned entities have the correct IDs populated on databases that support batch generated keys

Co-authored-by: HidekiSugimoto189 <21981922+HidekiSugimoto189@users.noreply.github.com>

* matrix-testで自動採番カラムのテストができるように修正
加えてCopilotが修正した部分の微調整

* testの微調整

* Update src/main/java/jp/co/future/uroborosql/tx/LocalTransactionContext.java

BULK_INSERT, ENTITY_BULK_INSERT でgeneratedKeysを使用する場合はあるので、この条件分岐はこのままでよい

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: HidekiSugimoto189 <21981922+HidekiSugimoto189@users.noreply.github.com>
Co-authored-by: Hideki Sugimoto <h.sugimoto.24@future.co.jp>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

10 of 10 new or added lines in 4 files covered. (100.0%)

9224 of 10158 relevant lines covered (90.81%)

0.91 hits per line