IgniteUI / igniteui-webcomponents / 19498298080

98%

push

github

fix(dialog): `keepOpenOnEscape` should prevent dialog from closing on Escape key press (#1986)

Chromium based browsers have a default behavior of
firing a `close` event when the Escape key is repeatedly pressed.
Since that event cannot be cancelled, keep the dialog open
when `keepOpenOnEscape` is set to true.

A better fix would be to use the `closedby` property
but unfortunately that is not supported in Safari.

Closes #1983

5291 of 5559 branches covered (95.18%)

Branch coverage included in aggregate %.

21 of 21 new or added lines in 1 file covered. (100.0%)

35277 of 35741 relevant lines covered (98.7%)

1593.83 hits per line