19491336680
61%

Ran 19 Nov 2025 08:03AM UTC

Jobs 1

Files 704

Run time 4min

Badge

Embed ▾

Committed 19 Nov 2025 05:51AM UTC coverage: 61.332% (+10.0%) from 51.294%

Build # 19491336680

Build Type

push

github

Committed by

web-flow

Commit Message

feat: make key manager stateless (#7550)

Description
---
Changes the key manager to make it stateless. 
This allows the key manager to only work from view and spend keys. 
Removes all async from the key manager.

Motivation and Context
---
Simplify the usage of the key manager


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
  * Hardware ledger wallet support and new wallet types.

* **Improvements**
* Key-management and transaction APIs now operate synchronously for more
predictable behavior.
* Memo construction, transaction signing, and error reporting refined
for more reliable submissions and clearer diagnostics.

* **Bug Fixes**
* Improved memo creation and wallet address error handling to reduce
failed transactions.

* **Refactor**
* Large internal modernization of key-management, wallet, and test
infrastructure (performance and maintainability).
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: stringhandler <stringhandler@protonmail.com>

Run Details

2156 of 4401 new or added lines in 81 files covered. (48.99%)

271 existing lines in 19 files now uncovered.

70402 of 114788 relevant lines covered (61.33%)

228492.92 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
1	94.69	0.0%	base_layer/common_types/src/seeds/cipher_seed.rs
1	64.1	64.1%	base_layer/transaction_components/src/multisig/script.rs
1	0.0	0.0%	base_layer/wallet/src/legacy_transaction_protocol/mod.rs
1	0.0	0.0%	base_layer/wallet/src/transaction_service/mod.rs
1	41.31	-6.39%	base_layer/wallet/src/transaction_service/storage/sqlite_db.rs
2	99.4	15.94%	base_layer/transaction_components/src/test_helpers/test_helpers_functions.rs
2	1.89	0.0%	base_layer/wallet/src/legacy_transaction_protocol/sender.rs
2	29.12	0.0%	base_layer/wallet/src/storage/database.rs
2	0.0	0.0%	base_layer/wallet/src/transaction_service/protocols/fetch_claim_burn_merkle_proofs.rs
2	0.0	0.0%	base_layer/wallet/src/utxo_scanner_service/initializer.rs
2	0.0	0.0%	base_layer/wallet/src/utxo_scanner_service/uxto_scanner_service_builder.rs
4	0.0	0.0%	base_layer/wallet/src/transaction_service/protocols/check_faux_transaction_status.rs
5	97.51		base_layer/transaction_components/src/key_manager/key_id.rs
5	79.17	36.74%	base_layer/transaction_components/src/transaction_components/one_sided.rs
5	0.0		base_layer/transaction_key_manager/src/legacy_key_manager/initializer.rs
6	0.0		base_layer/transaction_key_manager/src/legacy_key_manager/error.rs
7	75.19	0.8%	base_layer/core/src/blocks/pre_mine/mod.rs
7	0.0	0.0%	base_layer/transaction_components/src/key_manager/error.rs
8	0.0	0.0%	base_layer/transaction_components/src/transaction_components/unblinded_output.rs
8	0.0	0.0%	base_layer/wallet/src/utxo_scanner_service/utxo_scanner_task.rs
9	92.96	92.96%	base_layer/transaction_components/src/offline_signing/offline_signer.rs
9	0.0		base_layer/transaction_key_manager/src/legacy_key_manager/memory_key_manager.rs
10	65.47	0.77%	base_layer/core/src/test_helpers/blockchain.rs
10	94.46	68.72%	base_layer/transaction_components/src/coinbase_builder.rs
11	0.0	0.0%	applications/minotari_ledger_wallet/comms/src/accessor_methods.rs
12	60.86	5.41%	base_layer/core/src/chain_storage/blockchain_database.rs
13	85.43	-12.86%	applications/minotari_ledger_wallet/common/src/common_types.rs
14	94.92	17.17%	base_layer/transaction_components/src/consensus/consensus_constants.rs
15	91.07	62.91%	base_layer/transaction_components/src/transaction_builder/builder.rs
18	0.0	0.0%	base_layer/transaction_components/src/multisig/session.rs
19	0.0	0.0%	base_layer/wallet/src/output_manager_service/tasks/txo_validation_task.rs
21	88.57	88.57%	base_layer/transaction_components/src/offline_signing/one_sided_signer.rs
24	77.59	41.59%	base_layer/transaction_components/src/transaction_components/wallet_output_builder.rs
25	0.0	0.0%	base_layer/wallet/src/wallet.rs
27	0.0	0.0%	base_layer/wallet/src/output_manager_service/recovery/standard_outputs_recoverer.rs
28	0.0		base_layer/transaction_key_manager/src/legacy_key_manager/wallet_types.rs
34	7.76	-0.17%	base_layer/wallet/src/output_manager_service/storage/sqlite_db/output_sql.rs
36	48.87	4.76%	base_layer/transaction_components/src/transaction_components/wallet_output.rs
91	47.7		base_layer/transaction_components/src/key_manager/wallet_types.rs
106	0.0		base_layer/transaction_key_manager/src/legacy_key_manager/interface.rs
108	10.29	-0.78%	base_layer/wallet/src/output_manager_service/storage/sqlite_db/mod.rs
133	0.0	0.0%	base_layer/wallet/src/output_manager_service/storage/database/mod.rs
135	0.0	0.0%	base_layer/wallet/src/transaction_service/service.rs
156	0.0		base_layer/transaction_key_manager/src/legacy_key_manager/wrapper.rs
297	0.0	0.0%	base_layer/wallet/src/output_manager_service/service.rs
379	61.25		base_layer/transaction_components/src/key_manager/manager.rs
433	0.0		base_layer/transaction_key_manager/src/legacy_key_manager/inner.rs

Uncovered Existing Lines

Lines	Coverage	∆	File
1	65.47	0.77%	base_layer/core/src/test_helpers/blockchain.rs
1	94.46	68.72%	base_layer/transaction_components/src/coinbase_builder.rs
1	84.68	72.75%	base_layer/transaction_components/src/transaction_components/memo_field.rs
1	0.0	0.0%	base_layer/wallet/src/output_manager_service/recovery/standard_outputs_recoverer.rs
1	10.29	-0.78%	base_layer/wallet/src/output_manager_service/storage/sqlite_db/mod.rs
1	0.0	0.0%	base_layer/wallet/src/utxo_scanner_service/utxo_scanner_task.rs
2	6.25	-1.56%	base_layer/common_types/src/transaction.rs
2	56.91	1.73%	comms/core/src/connectivity/manager.rs
3	0.0	0.0%	applications/minotari_ledger_wallet/comms/src/accessor_methods.rs
3	0.0	0.0%	base_layer/transaction_components/src/key_manager/error.rs
3	0.0	0.0%	base_layer/wallet/src/output_manager_service/storage/database/mod.rs
4	86.49	0.0%	common_sqlite/src/connection.rs
5	0.0	0.0%	base_layer/wallet/src/transaction_service/service.rs
7	85.43	-12.86%	applications/minotari_ledger_wallet/common/src/common_types.rs
12	0.0	0.0%	base_layer/wallet/src/output_manager_service/service.rs
16	36.33	-2.53%	base_layer/wallet/src/transaction_service/storage/models.rs
24	15.15	-10.39%	base_layer/transaction_key_manager/src/storage/sqlite_db/mod.rs
25	60.86	5.41%	base_layer/core/src/chain_storage/blockchain_database.rs
159	41.31	-6.39%	base_layer/wallet/src/transaction_service/storage/sqlite_db.rs

Jobs

ID	Job ID	Ran	Files	Coverage
1	19491336680.1	19 Nov 2025 08:03AM UTC	704	61.33	GitHub Action Run

tari-project / tari / 19491336680
61%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 19491336680

tari-project / tari / 19491336680 61%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 19491336680

tari-project / tari / 19491336680
61%

README BADGES
x