kubernetes-sigs / karpenter / 19465313043

80%

main: 81%

Pull #2639

github

Fix topology spread constraint with nodeAffinityPolicy: Honor

This commit fixes issue #2623 where topology spread constraints with
nodeAffinityPolicy: Honor were not correctly considering node affinity
requirements when calculating topology domains.

Problem:
When a pod has topologySpreadConstraints with nodeAffinityPolicy: Honor,
Karpenter was incorrectly including ALL topology domains instead of only
those matching the pod's nodeSelector/affinity. This caused 'unsatisfiable
topology constraint' errors even when valid nodes could be provisioned.

Solution:
- Updated TopologyDomainGroup to track both taints AND requirements for
  each topology domain
- Modified ForEachDomain to use TopologyNodeFilter that considers both
  nodeTaintsPolicy and nodeAffinityPolicy
- Added matchesRequirements check to filter domains by node requirements

Example scenario (from issue #2623):
- NodePool A: capacity-spread=1, taint workload-group=app:NoSchedule
- NodePool B: capacity-spread=2-10, no taint
- Pod: nodeSelector workload-group=app, tolerates taint, topology spread
  with nodeAffinityPolicy: Honor

Before: Karpenter considered domains 1-10, causing unsatisfiable constraint
After: Karpenter correctly considers only domain 1

Fixes #2623

40 of 40 new or added lines in 4 files covered. (100.0%)

11817 of 14547 relevant lines covered (81.23%)

120246.15 hits per line