databendlabs / openraft / 19464825609

88%

Build Type

push

github

Committed by drmingdrmer

Commit Message

change: in 0.10.0: remove `Default` from `RaftVote` trait bounds

Remove the `Default` bound from `RaftVote` trait since a `Vote` always requires
a `node_id` and a truly default value is semantically meaningless. This prepares
for making `LeaderId::node_id()` return a non-Option value.

Changes:
- Add `RaftServerMetrics::new_empty()` to create initial server metrics with proper vote
- Update `RaftMetrics::new_initial()` to use `Vote::new_with_default_term()`
- Update `RaftState::default()` to require `NodeId: Default` and create proper vote for testing

Upgrade tip:

If you implement custom `RaftVote`, you no longer need to implement `Default`.

For code that used `Vote::default()`, replace with:
- `VoteOf::<C>::new_with_default_term(node_id)` for creating initial votes
- `RaftServerMetrics::new_empty(id)` for creating empty server metrics

Run Details

23 of 23 new or added lines in 4 files covered. (100.0%)

16 existing lines in 4 files now uncovered.

13148 of 14266 relevant lines covered (92.16%)

150912.74 hits per line