Alan-Jowett / bdd_test / 19308414831

88%

push

github

Fix PR #42 review feedback and enhance visualization system (#43)

* Fix PR review feedback issues

- Fix ODR violation in cudd_convert.hpp by adding inline keyword
- Fix CMake logic error in run_bdd_test.cmake for edge case handling
- Fix spacing issue and enable test cases in test_bdd_iterators.cpp
- Fix CUDD iterator terminal color calculation and edge labels
- Update CMake test targets to use TARGET_FILE generator expression
- Fix CONTRIBUTING.md copy command source path
- Add language specifiers to markdown code blocks

Resolves multiple code review issues including build errors,
logical bugs, and documentation improvements.

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Improve PNG visualization generation script

- Skip large DOT files (>100KB) that take too long to process
- Add progress indicators showing current file and progress count
- Skip already up-to-date PNG files to avoid redundant work
- Show file sizes in processing output for better visibility
- Improve summary statistics with detailed counts
- Fix script to run from project root instead of script directory

Successfully generated 148 new PNG files while skipping 8 large files
that would have taken excessive time to convert (some >9MB).

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Add generated PNG visualizations for all DOT files

Generated PNG files for all appropriately-sized DOT files using the
improved visualization script. This ensures complete visual coverage
of BDD and expression tree diagrams across all test cases and backends.

- Added PNG files for CUDD, TeDDy, and reordered test outputs
- Covered all expression types and edge cases
- Skipped extremely large files (>100KB) for performance
- Total coverage: 192 PNG files for 188 DOT files (102.1%)

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

---------

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>

1256 of 1700 branches covered (73.88%)

Branch coverage included in aggregate %.

1146 of 1362 relevant lines covered (84.14%)

71895.26 hits per line