ovn-kubernetes / ovn-kubernetes / 19292524194

56%

master: 57%

Build Type

Pull #5413

github

Committed by ricky-rav

Commit Message

Cluster manager shouldn't error out on localnets with no subnet

Localnets without a subnet specified are perfectly valid, but cluster manager will keep erroring out because of len(nInfo.Subnets()) > 0. This produces a red herring in the logs, where we retry to create a secondaryNetworkClusterManager 15 times until we give up:

I0724 18:43:21.377878      16 controller.go:257] Controller [clustermanager-nad-controller network controller]: error found while processing gh25b_tenant-blue: [clustermanager-nad-controller network controller]: failed to ensure network gh25b_tenant-blue: failed to create network gh25b_tenant-blue: no cluster network controller to manage topology

Let's not consider this an error when ensuring a network.

Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>

Pull Request Pull Request #5413: Cluster manager shouldn't error out on localnets with no subnet

Run Details

3 of 3 new or added lines in 1 file covered. (100.0%)

15 existing lines in 4 files now uncovered.

39515 of 73799 relevant lines covered (53.54%)

436.18 hits per line