umputun / local-docs-mcp / 19291931996

86%

Build Type

push

github

Committed by umputun

Commit Message

test: improve code quality with comprehensive testing and fixes

address code review findings with critical bug fixes, enhanced test
coverage, and improved error handling across scanner package.

critical fixes:
- fix timer resource leak in cached scanner watchLoop
- add error logging for file watcher failures
- remove unused runTestMutex variable

test improvements:
- add concurrency tests (concurrent scans, invalidation, close scenarios)
- add security edge case tests (symlinks, malformed paths, unicode)
- replace time.Sleep with assert.Eventually for reliability
- add channel synchronization for test coordination
- add run() function tests with stdout redirection

code quality:
- add debug logging for skipped scanner errors
- remove dead code (invalidateCh field and constant)
- switch from filepath.Walk to filepath.WalkDir for performance
- fix errors.Is misuse in main.go

documentation:
- update README to reflect always-on caching behavior
- add missing --max-file-size and --dbg flags to documentation

Run Details

14 of 22 new or added lines in 2 files covered. (63.64%)

1 existing line in 1 file now uncovered.

572 of 666 relevant lines covered (85.89%)

18.08 hits per line