open-source-parsers / jsoncpp / 19290584406

65%

push

github

Return false in Reader::readValue when stack limit is exceeded (#1619)

jsoncpp, as a shared library, should not call `abort` merely because there's an error reading a value.

See https://en.cppreference.com/w/c/program/abort, `abort` should only be called to **abnormally** cause the program to exit. Functions inserted by `atexit` are also not called, meaning that the host program may have not cleaned up resources properly. But here, exceeding stack limit isn't a sign of abnormalty.

`exit` is not a good substitute either, see the `exit-in-shared-library` from Debian:
https://lintian.debian.org/tags/exit-in-shared-library.html

Fix #1618

In this case, returning false seems like a better idea.

Co-authored-by: Jordan Bayles <bayles.jordan@gmail.com>

6336 of 12448 branches covered (50.9%)

Branch coverage included in aggregate %.

5838 of 6182 relevant lines covered (94.44%)

10221.46 hits per line