umputun / cronn / 19245576693

75%

Build Type

push

github

Committed by web-flow

Commit Message

Add command editing and custom date for manual job execution (#48)

* feat: add command editing and custom date for manual job execution

allow users to edit commands and provide custom dates when manually triggering jobs:

- add confirmation modal with editable command textarea
- add optional date input (YYYYMMDD format) for template variable override
- track executed command separately from base job command in database
- add executed_command column to executions table
- preserve original job identity while executing edited commands
- add JobID field to ManualJobRequest to prevent duplicate job entries
- implement jobFuncWithEditedCommand for executing modified commands
- add history UI toggle to view executed vs base commands
- display star icon for customized executions in history
- add client-side and server-side date validation
- update JobEventHandler interface with executedCommand parameter

comprehensive test coverage:
- service layer: custom date template parsing, edited command execution
- web layer: form data parsing, date validation, edited command handling
- persistence layer: executed command storage and retrieval

* fix: address critical issues in manual job execution

fix database migration, timezone handling, and repeater preservation:

- add database migration to add executed_command column to existing databases
- fix timezone issue by using ParseInLocation with time.Local for custom dates
- preserve Repeater (retry logic) from original job for manual runs
- add comprehensive tests for migration, timezone handling, and repeater preservation

this fixes issues where:
- existing deployments would crash with "no such column: executed_command"
- custom dates would be off by one day in negative UTC offset timezones
- manual runs would ignore job-specific retry configuration

* refactor: extract duplicated job execution logic and organize frontend code

- extract runJobWithCommand method to eliminate 170 lines of duplication between jobFun... (continued)

Run Details

137 of 161 new or added lines in 3 files covered. (85.09%)

1 existing line in 1 file now uncovered.

2333 of 3109 relevant lines covered (75.04%)

36.27 hits per line