ben-manes / caffeine / #5117

100%

master: 100%

push

github

adjust discarding an in-flight refresh to be more aggressive

This can only happen if refreshIfNeeded was concurrent with the removal
so a dangling refresh was present. When the refresh completes it
validates the entry's write timestamp for ABA protection, which due to
nano time will be different. Ideally we would also verify the node's
reference identity in case a custom Ticker was used, but this requires
more complexity than its worth. Since discarding is inexpensive a
stronger guard seems worthwhile and a more consistent code pattern.

3814 of 3820 branches covered (99.84%)

6 of 6 new or added lines in 1 file covered. (100.0%)

7836 of 7836 relevant lines covered (100.0%)

1.0 hits per line