• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

stacklok / toolhive / 19230314998
51%

Build:
DEFAULT BRANCH: main
Ran 10 Nov 2025 11:44AM UTC
Jobs 1
Files 360
Run time 335min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

10 Nov 2025 11:38AM UTC coverage: 48.886% (-0.002%) from 48.888%
19230314998

push

github

web-flow
Do not convert volume target path to Windows style, implement tilde expansion for Windows (#2488)

Since we deal with Linux containers, the volume target path should always be a Unix style path, even on Windows. Prior to this, the code would convert the target path to a Windows style path on Windows hosts due to the use of filepath.Clean. This PR changes the code to use path.Clean for the target instead, which always produces a Unix style path. Pre-existing validation ensures that the user cannot pass Windows style paths as input.

Another issue which was discovered by @danbarr as part of this was inconsistent handling of tilde expansion (i.e. converting ~/foo to an absolute path with the user's home folder). This was exacerbated by ToolHive using hand-rolled code to do absolute path expansion when there is a function in the Go standard library to do this. The new code explicitly checks to see if the path starts with ~ on Windows hosts, replaces it with the contents of the USERPROFILE env var if true, and then uses the Go standard library to convert to an absolute path.

12 of 18 new or added lines in 2 files covered. (66.67%)

1 existing line in 1 file now uncovered.

23152 of 47359 relevant lines covered (48.89%)

36.09 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
6
54.16
-0.14% pkg/container/docker/client.go

Uncovered Existing Lines

Lines Coverage ∆ File
1
54.16
-0.14% pkg/container/docker/client.go
Jobs
ID Job ID Ran Files Coverage
1 19230314998.1 10 Nov 2025 11:44AM UTC 360
48.89
GitHub Action Run
Source Files on build 19230314998
  • Tree
  • List 360
  • Changed 2
  • Source Changed 2
  • Coverage Changed 2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #19230314998
  • 84ebaa05 on github
  • Prev Build on main (#19224590346)
  • Next Build on main (#19232729768)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc