tari-project / tari / 19227006544
62%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 702
Run time 408min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 51.608% (-7.9%) from 59.471%
19227006544

push

github

web-flow 
feat: add deterministic transaction id (#7541)

Description
---
Added deterministic transaction IDs, which are an 8-byte (u64) hash
based on the transaction output hash in question and the wallet view
key.
- Any scanned or recovered wallet output will have the same transaction
ID across view or spend wallets.
- Sender wallets will be able to calculate the transaction ID for
receiver wallets if they need to, for that specific output.
- Sender wallets will use their change output as the determining output
hash for the transaction; this will result in the same transaction ID
being allocated upon wallet recovery. In the case of no change output,
the hash of the first ordered output will be used for the transaction
ID.
- For coin split transactions, the hash of the first ordered output will
be used for the transaction ID.

Fixed the issue with the Windows test build target link:
```
: error LNK2019: unresolved external symbol __imp_InitializeSecurityDescriptor referenced in function mdb_env_setup_locks
: error LNK2019: unresolved external symbol __imp_SetSecurityDescriptorDacl referenced in function mdb_env_setup_lock
```

Fixes #7485.

Motivation and Context
---
See #7485.

How Has This Been Tested?
---
Added unit tests.
Performed system-level testing.

What process can a PR reviewer use to test or verify this change?
---
Code review.
System-level testing.

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->


<!-- This is an auto-generated comm... (continued)

52 of 1260 new or added lines in 14 files covered. (4.13%)

9213 existing lines in 93 files now uncovered.

59188 of 114687 relevant lines covered (51.61%)

8172.79 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
66.15
 20.7% base_layer/common_types/src/tx_id.rs
1
36.36
 36.36% base_layer/transaction_components/src/lib.rs
1
0.0
 0.0% base_layer/wallet/src/transaction_service/handle.rs
2
0.0
 0.0% base_layer/transaction_components/src/multisig/session.rs
2
0.0
 0.0% base_layer/wallet/src/output_manager_service/storage/database/mod.rs
12
0.0
 -87.64% base_layer/transaction_components/src/offline_signing/offline_signer.rs
14
0.0
 0.0% base_layer/wallet/src/output_manager_service/recovery/standard_outputs_recoverer.rs
17
29.41
 -64.13% base_layer/transaction_components/src/transaction_builder/builder.rs
18
0.0
 0.0% base_layer/wallet/src/utxo_scanner_service/utxo_scanner_task.rs
28
11.47
 -0.22% base_layer/wallet/src/output_manager_service/storage/sqlite_db/mod.rs
36
0.0
 0.0% base_layer/wallet/src/output_manager_service/handle.rs
130
0.0
 0.0% base_layer/wallet/src/output_manager_service/service.rs
946
0.0
 0.0% base_layer/wallet/src/transaction_service/service.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
55.45
 0.0% base_layer/core/src/chain_storage/blockchain_database.rs
1
17.44
 -1.16% base_layer/core/src/chain_storage/error.rs
1
75.34
 -1.37% base_layer/node_components/src/blocks/chain_block.rs
1
0.0
 0.0% base_layer/wallet/src/output_manager_service/mod.rs
2
84.53
 -0.28% base_layer/common_types/src/tari_address/mod.rs
2
0.0
 0.0% base_layer/wallet/src/output_manager_service/handle.rs
2
0.0
 0.0% base_layer/wallet/src/output_manager_service/recovery/standard_outputs_recoverer.rs
3
66.15
 20.7% base_layer/common_types/src/tx_id.rs
3
0.0
 -16.67% base_layer/transaction_components/src/transaction_components/error.rs
3
0.0
 0.0% base_layer/wallet/src/utxo_scanner_service/utxo_scanner_task.rs
3
94.14
 -1.35% common/src/configuration/network.rs
4
85.25
 -1.44% infrastructure/tari_script/src/stack.rs
5
52.62
 -0.17% base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs
5
42.42
 -15.15% base_layer/transaction_components/src/transaction_components/one_sided.rs
5
36.84
 -26.32% base_layer/transaction_components/src/transaction_components/transaction_kernel_version.rs
5
60.17
 -0.7% comms/dht/src/connectivity/mod.rs
6
85.07
 -4.48% base_layer/transaction_components/src/transaction_components/transaction_kernel.rs
7
47.62
 -33.33% base_layer/transaction_components/src/transaction_components/transaction_output_version.rs
7
0.0
 0.0% base_layer/wallet/src/output_manager_service/service.rs
9
0.0
 -14.06% base_layer/transaction_components/src/offline_signing/models.rs
10
57.5
 -25.0% base_layer/transaction_components/src/validation/transaction/transaction_internal_validator.rs
10
0.0
 0.0% base_layer/wallet/src/transaction_service/service.rs
12
60.71
 -14.29% infrastructure/max_size/src/string.rs
13
0.0
 -100.0% base_layer/transaction_components/src/transaction_components/covenants/filters/identity.rs
14
31.82
 -63.64% base_layer/transaction_components/src/transaction_components/transaction_input_version.rs
15
42.31
 -57.69% base_layer/transaction_components/src/helpers/byte_counter.rs
16
51.43
 -45.71% base_layer/transaction_components/src/tari_proof_of_work/proof_of_work.rs
16
0.0
 -100.0% base_layer/transaction_components/src/transaction_components/covenants/filters/test.rs
18
38.71
 -58.06% base_layer/transaction_components/src/transaction_components/kernel_features.rs
18
44.9
 -36.73% base_layer/transaction_components/src/transaction_components/transaction.rs
18
72.53
 -19.78% base_layer/transaction_components/src/weight.rs
18
90.1
 -0.07% comms/core/src/peer_manager/peer_storage_sql.rs
19
0.0
 -47.5% base_layer/transaction_components/src/key_manager/memory_key_manager.rs
22
23.91
 -23.91% infrastructure/max_size/src/vec.rs
24
0.0
 -64.86% base_layer/transaction_components/src/multisig/script.rs
24
0.0
 -100.0% base_layer/transaction_components/src/transaction_components/covenants/filters/output_hash_eq.rs
26
0.0
 -100.0% base_layer/transaction_components/src/transaction_components/covenants/byte_codes.rs
26
0.0
 -100.0% base_layer/transaction_components/src/transaction_components/covenants/macros.rs
28
0.0
 -100.0% base_layer/transaction_components/src/format_currency.rs
28
0.0
 -90.32% base_layer/transaction_components/src/transaction_components/covenants/context.rs
28
0.0
 -100.0% base_layer/transaction_components/src/transaction_components/covenants/filters/not.rs
31
0.0
 -100.0% base_layer/transaction_components/src/transaction_components/covenants/filters/fields_preserved.rs
31
0.0
 -100.0% base_layer/transaction_components/src/transaction_components/covenants/filters/or.rs
31
0.0
 -100.0% base_layer/transaction_components/src/transaction_components/covenants/filters/xor.rs
31
64.62
 0.93% comms/core/src/connectivity/proactive_dialer.rs
32
0.0
 -100.0% base_layer/transaction_components/src/transaction_components/covenants/filters/and.rs
32
32.31
 -49.23% base_layer/transaction_components/src/transaction_components/output_type.rs
33
0.0
 -76.74% base_layer/transaction_components/src/transaction_components/side_chain/validator_node_exit.rs
34
36.21
 -58.62% base_layer/transaction_components/src/fee.rs
35
0.0
 -100.0% base_layer/transaction_components/src/transaction_components/covenants/filters/absolute_height.rs
35
88.56
 0.09% comms/core/src/peer_manager/manager.rs
37
15.91
 -84.09% base_layer/transaction_components/src/transaction_components/covenants/encoder.rs
40
0.0
 -100.0% base_layer/transaction_components/src/transaction_components/covenants/filters/fields_hashed_eq.rs
40
0.0
 -100.0% base_layer/transaction_components/src/transaction_components/covenants/test.rs
42
15.25
 -71.19% base_layer/transaction_components/src/transaction_components/range_proof_type.rs
43
44.11
 -6.52% base_layer/transaction_components/src/transaction_components/wallet_output.rs
44
0.0
 -57.14% base_layer/transaction_components/src/transaction_components/covenants/filters/filter.rs
45
6.67
 -60.0% base_layer/transaction_components/src/tari_proof_of_work/proof_of_work_algorithm.rs
48
66.67
 -13.22% base_layer/transaction_components/src/transaction_components/transaction_input.rs
51
0.0
 -100.0% base_layer/transaction_components/src/offline_signing/marshal_output_pair.rs
51
40.63
 -53.13% base_layer/transaction_components/src/transaction_components/side_chain/validator_node_signature.rs
60
92.46
 -0.01% comms/core/src/peer_manager/storage/database.rs
61
28.57
 -58.1% base_layer/transaction_components/src/transaction_components/side_chain/validator_node_registration.rs
65
27.1
 -60.75% base_layer/transaction_components/src/key_manager/tari_key_manager.rs
67
83.45
 -11.92% base_layer/transaction_components/src/test_helpers/test_helpers_functions.rs
68
25.89
 -60.71% base_layer/transaction_components/src/tari_proof_of_work/difficulty.rs
76
16.83
 -75.25% base_layer/transaction_components/src/consensus/consensus_encoding/hashing.rs
76
38.64
 -57.58% base_layer/transaction_components/src/transaction_components/covenants/covenant.rs
76
0.0
 -92.68% base_layer/transaction_components/src/transaction_components/covenants/output_set.rs
79
50.0
 -21.35% base_layer/transaction_components/src/aggregated_body.rs
86
35.16
 -47.25% base_layer/transaction_components/src/transaction_components/encrypted_data.rs
88
0.0
 -96.7% base_layer/transaction_components/src/transaction_components/covenants/decoder.rs
94
50.65
 -40.69% base_layer/transaction_components/src/validation/helpers.rs
96
0.0
 -88.89% base_layer/transaction_components/src/transaction_components/covenants/token.rs
103
36.46
 -35.76% base_layer/transaction_components/src/key_manager/wrapper.rs
104
18.58
 -56.83% base_layer/transaction_components/src/key_manager/interface.rs
117
49.77
 -27.21% base_layer/transaction_components/src/validation/aggregate_body/aggregate_body_internal_validator.rs
126
0.0
 -89.36% base_layer/transaction_components/src/transaction_components/covenants/arguments.rs
126
0.0
 -95.45% base_layer/transaction_components/src/transaction_components/covenants/filters/field_eq.rs
137
77.74
 -14.73% base_layer/transaction_components/src/consensus/consensus_constants.rs
159
35.86
 -63.35% base_layer/transaction_components/src/consensus/emission.rs
163
36.0
 -43.47% base_layer/transaction_components/src/transaction_components/wallet_output_builder.rs
173
26.9
 -59.66% base_layer/transaction_components/src/tari_amount.rs
214
42.1
 -17.26% base_layer/transaction_components/src/key_manager/inner.rs
232
0.0
 -87.64% base_layer/transaction_components/src/offline_signing/offline_signer.rs
264
43.85
 -45.75% base_layer/transaction_components/src/transaction_components/transaction_output.rs
360
0.0
 -89.33% base_layer/transaction_components/src/transaction_components/covenants/fields.rs
530
0.0
 -99.44% base_layer/transaction_components/src/transaction_components/test.rs
553
0.0
 -100.0% base_layer/transaction_components/src/offline_signing/mod.rs
594
0.0
 -91.24% base_layer/transaction_components/src/offline_signing/one_sided_signer.rs
630
25.74
 -69.0% base_layer/transaction_components/src/coinbase_builder.rs
1123
29.41
 -64.13% base_layer/transaction_components/src/transaction_builder/builder.rs
1269
11.93
 -72.43% base_layer/transaction_components/src/transaction_components/memo_field.rs
Jobs
ID Job ID Ran Files Coverage
1 19227006544.1 702
51.61
 GitHub Action Run
Source Files on build 19227006544