Alan-Jowett / bdd_test / 19213674854

88%

push

github

Fix cppcheck issues for clean static analysis (#20)

* Fix cppcheck issues for clean static analysis

Code quality improvements:

1. **Fixed const-correctness issues**:
   - Made 'manager' parameter const in write_bdd_to_dot() functions
   - Updated both implementation and header declarations

2. **Performance optimizations**:
   - Replaced raw loop with std::transform in bdd_graph.cpp
   - Added algorithm header for std::transform
   - Improved map insertion performance with try_emplace

3. **Removed dead code**:
   - Eliminated unused private function get_node_id()
   - Cleaned up expression_iterator class

4. **Updated CI configuration**:
   - Removed suppressions that are no longer needed
   - Cppcheck now runs cleanly with only essential suppressions

All cppcheck warnings and style issues have been resolved.
The code now passes static analysis without any suppressions
for the issues we fixed.

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Apply clang-format to ensure consistent code formatting

Fix line wrapping in main.cpp function signature to comply with
the project's clang-format configuration (100 character line limit).

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Remove unnecessary unusedFunction suppression from cppcheck

Since we removed the actual unused function (get_node_id) from the
codebase, we no longer need to suppress unusedFunction warnings.
This makes the cppcheck configuration cleaner and more precise.

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

---------

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>

647 of 763 branches covered (84.8%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 2 files covered. (100.0%)

601 of 645 relevant lines covered (93.18%)

221.5 hits per line