jas88 / TypeGuesser / 19211158218

89%

main: 90%

Build Type

Pull #13

github

Committed by jas88

Commit Message

Fix all 24 failing unit tests (377/377 tests now passing)

Core functionality fixes:
- Fixed PooledBuilder.ProcessString recursion causing double value counting
- Added SetInitialTypeHint method for type priming without processing values
- Fixed DatabaseTypeRequest.Max inverted type preference logic
- Fixed DatabaseTypeRequest.Width to return Size.ToStringLength only for numeric types
- Added null culture handling in TypeDeciderFactory and DateTimeTypeDecider
- Added value-based Equals/GetHashCode to GuessSettings
- Fixed TypeDeciderFactory.IsSupported to handle null types
- Fixed DecimalTypeDecider to handle null culture parameter

Exception handling improvements:
- Added JSON serialization support to MixedTypingException with backing field
- Changed TypeNotSupportedException from internal to public
- Improved error message format for TypeNotSupportedException

Test updates:
- Updated PooledBuilderTests.Reset to avoid forbidden mixed typing
- Fixed ExampleStringValues test to expect correct ValueCount (3 instead of 4)
- Updated Create_WithUnsupportedType test (Guid now supported via NeverGuessTheseTypeDecider)
- Updated IsSupported_WithUnsupportedType to use truly unsupported types
- Updated 7 ResourceString tests to match new error message formats
- Changed Assert.Throws to Assert.Catch in AdditionalCoverageTests for derived exceptions

All changes maintain backward compatibility and follow existing code patterns.

Pull Request Pull Request #13: Feature/test coverage improvements

Run Details

458 of 548 branches covered (83.58%)

Branch coverage included in aggregate %.

110 of 139 new or added lines in 10 files covered. (79.14%)

3 existing lines in 2 files now uncovered.

1254 of 1375 relevant lines covered (91.2%)

196396.54 hits per line