stacklok / toolhive / 19178688182

51%

push

github

Add Flusher interface to audit and authz middlewares (#2512)

Fixes #2509

The audit and authorization middleware responseWriter wrappers were
not implementing the http.Flusher interface, causing "Streaming not
supported" errors when using streamable-http proxy mode.

The streamable-http proxy checks for http.Flusher support when clients
send requests with Accept: text/event-stream header (per-request
streaming per MCP spec). When audit or authz middlewares wrapped the
ResponseWriter without implementing Flusher, the type assertion failed.

Changes:
- Add Flush() method to audit middleware responseWriter that delegates
  to the underlying ResponseWriter if it supports flushing
- Add Flush() method to authz ResponseFilteringWriter following the
  same pattern
- Rename authz ResponseFilteringWriter.Flush() to FlushAndFilter() to
  avoid confusion with the http.Flusher interface method
- Update authz tests to use FlushAndFilter()

This fix ensures streamable-http proxy mode works correctly when audit
or authz middlewares are enabled.

Signed-off-by: Dan Barr <6922515+danbarr@users.noreply.github.com>
Co-authored-by: Dan Barr <6922515+danbarr@users.noreply.github.com>

6 of 10 new or added lines in 3 files covered. (60.0%)

23117 of 47260 relevant lines covered (48.91%)

36.13 hits per line