databendlabs / openraft / 19124392610

88%

Build Type

push

github

Committed by drmingdrmer

Commit Message

change: Add `on_commit` `on_complete` to `Responder` trait

Add `ProgressResponder` and use it as default `Responder` that receives
`on_commit` and `on_complete` events.

- `on_commit` is called when a log entry is committed;
- `on_complete` is called when the log entry is applied to state machine
  or an error occur.

Replace OneshotResponder with ProgressResponder throughout the codebase to
provide both commit and completion(apply or error) notifications by default.

- Fix: #1460

Upgrade tip:

When not using application defined `Responder`, nothing todo.

Otherwise, update the implementation of `Responder` by adding
`on_commit` if needed, and replacing `send` with `on_complete`.

Run Details

109 of 113 new or added lines in 8 files covered. (96.46%)

2 existing lines in 2 files now uncovered.

12636 of 13832 relevant lines covered (91.35%)

134602.02 hits per line