kubevirt / containerized-data-importer / #5655

49%

Build Type

push

travis-ci

Committed by web-flow

Commit Message

Add InsecureSkipVerify support for ImageIO data source (#3944)

What this PR does / why we need it:

This PR adds support for skipping TLS certificate verification when using
ImageIO as a data source for DataVolumes. This enables warm migrations from
oVirt/RHV providers when "Skip certificate validation" is enabled.

The implementation includes:
- Added InsecureSkipVerify field to DataVolumeSourceImageIO API spec
- Added AnnInsecureSkipVerify annotation for passing the flag to importer pods
- Updated UpdateImageIOAnnotations to set the annotation when enabled
- Modified NewImageioDataSource to accept and use the insecureSkipVerify parameter
- Updated getOvirtClient to use tls.Insecure() when flag is true
- Modified createHTTPClient to configure TLSClientConfig.InsecureSkipVerify
- Updated all test cases to pass the new parameter

After the fix:

Warm migrations from oVirt/RHV providers now work correctly when certificate validation is skipped.
The CDI ImageIO importer can connect to oVirt ImageIO
services without requiring a valid CA certificate in a ConfigMap, as long as the InsecureSkipVerify flag is set to true in the DataVolume spec.

Example DataVolume usage:
```yaml
spec:
  source:
    imageio:
      url: "https://ovirt-engine.example.com/ovirt-engine/api"
      diskId: "disk-uuid"
      secretRef: "ovirt-credentials"
      insecureSkipVerify: true  # Skip TLS certificate validation
```

Which issue(s) this PR fixes:

Jira Ticket: https://issues.redhat.com/browse/CNV-71978

Release note:
```release-note
DataVolumes can now skip TLS certificate verification when importing from oVirt/RHV ImageIO sources
by setting `spec.source.imageio.insecureSkipVerify: true`.
```

Signed-off-by: Elad Hazan <ehazan@redhat.com>

Run Details

33 of 48 new or added lines in 7 files covered. (68.75%)

4 existing lines in 1 file now uncovered.

17246 of 29199 relevant lines covered (59.06%)

0.65 hits per line